Unverified Commit 0dcf19df authored by Kubernetes Submit Queue's avatar Kubernetes Submit Queue Committed by GitHub

Merge pull request #60268 from mikedanese/kmss

Automatic merge from submit-queue (batch tested with PRs 55637, 57461, 60268, 60290, 60210). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. kms: rename KMSService to KeyManagementService KMSService is redundant. Introduced in #55684 @kubernetes/sig-auth-api-reviews ```release-note NONE ```
parents e6c2a5de fc8ff61e
...@@ -46,7 +46,7 @@ const ( ...@@ -46,7 +46,7 @@ const (
// The gRPC implementation for envelope.Service. // The gRPC implementation for envelope.Service.
type gRPCService struct { type gRPCService struct {
// gRPC client instance // gRPC client instance
kmsClient kmsapi.KMSServiceClient kmsClient kmsapi.KeyManagementServiceClient
connection *grpc.ClientConn connection *grpc.ClientConn
} }
...@@ -64,7 +64,7 @@ func NewGRPCService(endpoint string) (Service, error) { ...@@ -64,7 +64,7 @@ func NewGRPCService(endpoint string) (Service, error) {
return nil, fmt.Errorf("connect remote KMS provider %q failed, error: %v", addr, err) return nil, fmt.Errorf("connect remote KMS provider %q failed, error: %v", addr, err)
} }
kmsClient := kmsapi.NewKMSServiceClient(connection) kmsClient := kmsapi.NewKeyManagementServiceClient(connection)
err = checkAPIVersion(kmsClient) err = checkAPIVersion(kmsClient)
if err != nil { if err != nil {
...@@ -99,7 +99,7 @@ func parseEndpoint(endpoint string) (string, error) { ...@@ -99,7 +99,7 @@ func parseEndpoint(endpoint string) (string, error) {
// Check the KMS provider API version. // Check the KMS provider API version.
// Only matching kmsapiVersion is supported now. // Only matching kmsapiVersion is supported now.
func checkAPIVersion(kmsClient kmsapi.KMSServiceClient) error { func checkAPIVersion(kmsClient kmsapi.KeyManagementServiceClient) error {
ctx, cancel := context.WithTimeout(context.Background(), timeout) ctx, cancel := context.WithTimeout(context.Background(), timeout)
defer cancel() defer cancel()
......
...@@ -124,7 +124,7 @@ func startTestKMSProvider() (*grpc.Server, error) { ...@@ -124,7 +124,7 @@ func startTestKMSProvider() (*grpc.Server, error) {
} }
server := grpc.NewServer() server := grpc.NewServer()
kmsapi.RegisterKMSServiceServer(server, &base64Server{}) kmsapi.RegisterKeyManagementServiceServer(server, &base64Server{})
go server.Serve(listener) go server.Serve(listener)
return server, nil return server, nil
} }
......
...@@ -4,7 +4,7 @@ syntax = "proto3"; ...@@ -4,7 +4,7 @@ syntax = "proto3";
package v1beta1; package v1beta1;
// This service defines the public APIs for remote KMS provider. // This service defines the public APIs for remote KMS provider.
service KMSService { service KeyManagementService {
// Version returns the runtime name and runtime version of the KMS provider. // Version returns the runtime name and runtime version of the KMS provider.
rpc Version(VersionRequest) returns (VersionResponse) {} rpc Version(VersionRequest) returns (VersionResponse) {}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment