pkg/lists: uncrustify Makefile

The problem with the changed piece of code is that it would - both call cp(1) multiple times if multiple *_LIST variables were non-empty (which is usually the case), and - try to evaluate stdout of the called commands as a shell script (which would be empty unless someone passed e.g. -v to that cp(1) but it's crazy to rely on things like this). So the functions should prepare arguments for a single copy command that is predictable and could be made verbose. Ouch.

pkg/lists: uncrustify Makefile
a86dd0c4 · Michael Shigorin · dc679621 · a86dd0c4
Commit a86dd0c4 authored Jan 20, 2015 by Michael Shigorin
Show whitespace changes
Inline Side-by-side

Showing with 4 additions and 4 deletions

Makefile pkg.in/lists/Makefile +4 -4

No files found.
--- a/pkg.in/lists/Makefile
+++ b/pkg.in/lists/Makefile
@@ -21,12 +21,12 @@ TARGET := $(BUILDDIR)/$(SUFFIX)
 all: $(TARGET) $(GLOBAL_DEBUG) $(DOTBASE) copy-lists copy-groups
 	@mp-commit "$(TARGET)" "requested $(SUFFIX) copied over"
+# env | sort -u | grep _LISTS | xargs cp
 copy-lists:
-	@# env | sort -u | grep _LISTS | xargs cp
+	@cp --parents -at $(TARGET) -- \
-	@$(foreach V, \
+		$(foreach V, \
 			$(filter %_LISTS,$(sort $(.VARIABLES))), \
-		$(if $(filter environment% file,$(origin $V)),\
+			$(if $(filter environment% file,$(origin $V)),$($V)))
-			$(shell cp --parents -at $(TARGET) -- $($V))))
 copy-groups:
 	@if [ -n "$(THE_GROUPS)$(MAIN_GROUPS)" ]; then \