shellcheck: Fix SC2045 issue

See, $ find . -name "*.sh" | xargs shellcheck -i SC2045 In ./roll-tarballs.sh line 220: for f in $(ls README* 2>/dev/null); do ^-----------------------^ SC2045: Iterating over ls output is fragile. Use globs. For more information: https://www.shellcheck.net/wiki/SC2045 -- Iterating over ls output is fragi... Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>

shellcheck: Fix SC2045 issue
2168bc68 · Mario Trangoni · 747a3374 · 2168bc68
Commit 2168bc68 authored Jan 31, 2021 by Mario Trangoni
Show whitespace changes
Inline Side-by-side

Showing with 3 additions and 2 deletions

roll-tarballs.sh roll-tarballs.sh +3 -2

No files found.
--- a/roll-tarballs.sh
+++ b/roll-tarballs.sh
@@ -217,8 +217,9 @@ rm -Rf "debian/"
 rm -Rf "nx-libs.spec"

 # very old release did not add any README
-for f in $(ls README* 2>/dev/null); do
-    mv -v "$f" "doc/";
+for f in README*; do
+    [[ -e "$f" ]] || break # handle the case of no README* files
+    mv -v "$f" "doc/"
 done

 # remove files, that we do not want in the tarballs (build cruft)