NXpicture.c: remove unneccessary check

Code can only be reached if pPicture is non-NULL. Besides, pPicture will be accessed later anyway, regardless of this check. Finding of PVS Studio: "V547 Expression 'pPicture != NULL' is always true."

NXpicture.c: remove unneccessary check
5871100d · Ulrich Sibiller · 41bf8397 · 5871100d
Commit 5871100d authored Aug 03, 2020 by Ulrich Sibiller
Show whitespace changes
Inline Side-by-side

Showing with 0 additions and 3 deletions

NXpicture.c nx-X11/programs/Xserver/hw/nxagent/NXpicture.c +0 -3

No files found.
--- a/nx-X11/programs/Xserver/hw/nxagent/NXpicture.c
+++ b/nx-X11/programs/Xserver/hw/nxagent/NXpicture.c
@@ -320,8 +320,6 @@ static PicturePtr createSourcePicture(void)
    if (!pPicture)
      return 0;

-    if (pPicture != NULL)
-    {
    DevUnion *ppriv = (DevUnion *) (pPicture + 1);

    for (int i = 0; i < picturePrivateCount; ++i)
@@ -340,7 +338,6 @@ static PicturePtr createSourcePicture(void)
    pPicture -> devPrivates = ppriv;

    nxagentPicturePriv(pPicture) -> picture = 0;
-    }

    pPicture->pDrawable = 0;
    pPicture->pFormat = 0;