Reconnect.c: fix possible realloc() memory loss

"V701 realloc() possible leak: when realloc() fails in allocating memory, original pointer 'nxagentReconnectErrorMessage' is lost. Consider assigning realloc() to a temporary pointer."

Reconnect.c: fix possible realloc() memory loss
8bb77997 · Ulrich Sibiller · 948bbe50 · 8bb77997
Commit 8bb77997 authored Jan 04, 2021 by Ulrich Sibiller
Show whitespace changes
Inline Side-by-side

Showing with 6 additions and 2 deletions

Reconnect.c nx-X11/programs/Xserver/hw/nxagent/Reconnect.c +6 -2

No files found.
--- a/nx-X11/programs/Xserver/hw/nxagent/Reconnect.c
+++ b/nx-X11/programs/Xserver/hw/nxagent/Reconnect.c
@@ -788,12 +788,16 @@ void nxagentSetReconnectError(int id, char *format, ...)
      size = (size ? size * 2 : NXAGENT_RECONNECT_DEFAULT_MESSAGE_SIZE);
    }

-    nxagentReconnectErrorMessage = realloc(nxagentReconnectErrorMessage, size);
+    char *tmp = realloc(nxagentReconnectErrorMessage, size);

-    if (nxagentReconnectErrorMessage == NULL)
+    if (tmp == NULL)
    {
      FatalError("realloc failed");
    }
+    else
+    {
+      nxagentReconnectErrorMessage = tmp;
+    }
  }

  return;