FSWrap: fix potential leak in copy_string_list

If list_count is 0, dst would be allocated and leaked. Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com> Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com> Backported-to-NX-by: Ulrich Sibiller <uli42@gmx.de>

FSWrap: fix potential leak in copy_string_list
dce81504 · Ander Conselvan de Oliveira · Ulrich Sibiller · 0f714869 · dce81504
Commit dce81504 authored Mar 24, 2011 by Ander Conselvan de Oliveira Committed by Ulrich Sibiller Oct 19, 2016
Show whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

FSWrap.c nx-X11/lib/X11/FSWrap.c +1 -1

No files found.
--- a/nx-X11/lib/X11/FSWrap.c
+++ b/nx-X11/lib/X11/FSWrap.c
@@ -131,7 +131,7 @@ copy_string_list(
    char **string_list_ret, **list_src, **list_dst, *dst;
    int length, count;

-    if (string_list == NULL)
+    if (string_list == NULL || list_count == 0)
 	return (char **) NULL;

    string_list_ret = (char **) Xmalloc(sizeof(char *) * list_count);