Skip to content

bugzilla
bugzilla
Commit 0ca30382 authored by terry%netscape.com's avatar terry%netscape.com
Browse files
Options

Patch by Andrew Anderson <andrew@redhat.com>. Many minor bugfixes and cleanup.

parent 1cf02cc7
Expand all Show whitespace changes
Inline Side-by-side
Showing with 194 additions and 171 deletions
CGI.pl
View file @ 0ca30382
...@@ -39,8 +39,8 @@ sub GeneratePersonInput { ...@@ -39,8 +39,8 @@ sub GeneratePersonInput {
} }
sub GeneratePeopleInput { sub GeneratePeopleInput {
my ($field, $def_value) = (@_); my ($field, $size, $def_value) = (@_);
return "<INPUT NAME=\"$field\" SIZE=45 VALUE=\"$def_value\">"; return "<INPUT NAME=\"$field\" SIZE=\"$size\" VALUE=\"$def_value\">";
} }
...@@ -187,15 +187,15 @@ sub make_options { ...@@ -187,15 +187,15 @@ sub make_options {
} }
$last = $item; $last = $item;
if ($isregexp ? $item =~ $default : $default eq $item) { if ($isregexp ? $item =~ $default : $default eq $item) {
$popup .= "<OPTION SELECTED VALUE=\"$item\">$item"; $popup .= " <OPTION SELECTED VALUE=\"" . url_quote($item) . "\">" . url_decode($item) . "\n";
$found = 1; $found = 1;
} else { } else {
$popup .= "<OPTION VALUE=\"$item\">$item"; $popup .= " <OPTION VALUE=\"" . url_quote($item) . "\">" . url_decode($item) . "\n";
} }
} }
} }
if (!$found && $default ne "") { if (!$found && $default ne "") {
$popup .= "<OPTION SELECTED>$default"; $popup .= " <OPTION SELECTED>$default\n";
} }
return $popup; return $popup;
} }
...@@ -203,9 +203,9 @@ sub make_options { ...@@ -203,9 +203,9 @@ sub make_options {
sub make_popup { sub make_popup {
my ($name,$src,$default,$listtype,$onchange) = (@_); my ($name,$src,$default,$listtype,$onchange) = (@_);
my $popup = "<SELECT NAME=$name"; my $popup = "<SELECT NAME=\"$name\"";
if ($listtype > 0) { if ($listtype > 0) {
$popup .= " SIZE=5"; $popup .= " SIZE=\"5\"";
if ($listtype == 2) { if ($listtype == 2) {
$popup .= " MULTIPLE"; $popup .= " MULTIPLE";
} }
...@@ -246,7 +246,8 @@ sub confirm_login { ...@@ -246,7 +246,8 @@ sub confirm_login {
if ($enteredlogin !~ /^[^@, ]*@[^@, ]*\.[^@, ]*$/) { if ($enteredlogin !~ /^[^@, ]*@[^@, ]*\.[^@, ]*$/) {
print "Content-type: text/html\n\n"; print "Content-type: text/html\n\n";
print "<H1>Invalid e-mail address entered.</H1>\n"; PutHeader("Invalid e-mail address entered");
print "The e-mail address you entered\n"; print "The e-mail address you entered\n";
print "(<b>$enteredlogin</b>) didn't match our minimal\n"; print "(<b>$enteredlogin</b>) didn't match our minimal\n";
print "syntax checking for a legal email address. A legal\n"; print "syntax checking for a legal email address. A legal\n";
...@@ -302,7 +303,7 @@ To use the wonders of bugzilla, you can use the following: ...@@ -302,7 +303,7 @@ To use the wonders of bugzilla, you can use the following:
my $enteredcryptpwd = crypt($enteredpwd, substr($realcryptpwd, 0, 2)); my $enteredcryptpwd = crypt($enteredpwd, substr($realcryptpwd, 0, 2));
if ($realcryptpwd eq "" || $enteredcryptpwd ne $realcryptpwd) { if ($realcryptpwd eq "" || $enteredcryptpwd ne $realcryptpwd) {
print "Content-type: text/html\n\n"; print "Content-type: text/html\n\n";
print "<H1>Login failed.</H1>\n"; PutHeader("Login failed.");
print "The username or password you entered is not valid.\n"; print "The username or password you entered is not valid.\n";
print "Please click <b>Back</b> and try again.\n"; print "Please click <b>Back</b> and try again.\n";
exit; exit;
...@@ -344,7 +345,7 @@ To use the wonders of bugzilla, you can use the following: ...@@ -344,7 +345,7 @@ To use the wonders of bugzilla, you can use the following:
if ($loginok ne "1") { if ($loginok ne "1") {
print "Content-type: text/html\n\n"; print "Content-type: text/html\n\n";
print "<H1>Please log in.</H1>\n"; PutHeader("Please log in.");
print "I need a legitimate e-mail address and password to continue.\n"; print "I need a legitimate e-mail address and password to continue.\n";
if (!defined $nexturl || $nexturl eq "") { if (!defined $nexturl || $nexturl eq "") {
# Sets nexturl to be argv0, stripping everything up to and # Sets nexturl to be argv0, stripping everything up to and
......
bug_form.pl
View file @ 0ca30382
...@@ -39,7 +39,7 @@ select ...@@ -39,7 +39,7 @@ select
short_desc, short_desc,
date_format(creation_ts,'Y-m-d') date_format(creation_ts,'Y-m-d')
from bugs from bugs
where bug_id = $::FORM{'id'}"; where bug_id = '" . $::FORM{'id'} . "'";
SendSQL($query); SendSQL($query);
my %bug; my %bug;
......
changepassword.cgi
View file @ 0ca30382
...@@ -24,20 +24,20 @@ require "CGI.pl"; ...@@ -24,20 +24,20 @@ require "CGI.pl";
confirm_login(); confirm_login();
if (! defined $::FORM{'pwd1'}) { if (! defined $::FORM{'pwd1'}) {
print "Content-type: text/html print "Content-type: text/html\n\n";
PutHeader("Change your password");
<H1>Change your password</H1> print "
<form method=post> <FORM METHOD=\"post\">
<table> <table>
<tr> <tr>
<td align=right>Please enter the new password for <b>$::COOKIE{'Bugzilla_login'}</b>:</td> <TD ALIGN=\"right\">Please enter the new password for <b>$::COOKIE{'Bugzilla_login'}</b>:</td>
<td><input type=password name=pwd1></td> <TD><INPUT TYPE=\"password\" NAME=\"pwd1\"></td>
</tr> </tr>
<tr> <tr>
<td align=right>Re-enter your new password:</td> <TD ALIGN=\"right\">Re-enter your new password:</td>
<td><input type=password name=pwd2></td> <TD><INPUT TYPE=\"password\" name=\"pwd2\"></td>
</table> </table>
<input type=submit value=Submit>\n"; <INPUT TYPE=\"submit\" VALUE=\"Submit\">\n";
exit; exit;
} }
...@@ -85,4 +85,4 @@ SendSQL("update logincookies set cryptpassword = '$encrypted' where cookie = $:: ...@@ -85,4 +85,4 @@ SendSQL("update logincookies set cryptpassword = '$encrypted' where cookie = $::
print "<H1>OK, done.</H1> print "<H1>OK, done.</H1>
Your new password has been set. Your new password has been set.
<p> <p>
<a href=query.cgi>Back to query page.</a>\n"; <A HREF=\"query.cgi\">Back to query page.</A>\n";
colchange.cgi
View file @ 0ca30382
...@@ -24,8 +24,6 @@ use strict; ...@@ -24,8 +24,6 @@ use strict;
require "CGI.pl"; require "CGI.pl";
print "Content-type: text/html\n";
# The master list not only says what fields are possible, but what order # The master list not only says what fields are possible, but what order
# they get displayed in. # they get displayed in.
...@@ -49,8 +47,8 @@ if (defined $::FORM{'rememberedquery'}) { ...@@ -49,8 +47,8 @@ if (defined $::FORM{'rememberedquery'}) {
my $list = join(" ", @collist); my $list = join(" ", @collist);
print "Set-Cookie: COLUMNLIST=$list ; path=/ ; expires=Sun, 30-Jun-2029 00:00:00 GMT\n"; print "Set-Cookie: COLUMNLIST=$list ; path=/ ; expires=Sun, 30-Jun-2029 00:00:00 GMT\n";
print "Refresh: 0; URL=buglist.cgi?$::FORM{'rememberedquery'}\n"; print "Refresh: 0; URL=buglist.cgi?$::FORM{'rememberedquery'}\n";
print "\n"; print "Content-type: text/html\n\n";
print "<TITLE>What a hack.</TITLE>\n"; PutHeader("What a hack");
print "Resubmitting your query with new columns...\n"; print "Resubmitting your query with new columns...\n";
exit; exit;
} }
...@@ -61,6 +59,9 @@ if (defined $::COOKIE{'COLUMNLIST'}) { ...@@ -61,6 +59,9 @@ if (defined $::COOKIE{'COLUMNLIST'}) {
@collist = @::default_column_list; @collist = @::default_column_list;
} }
print "Content-type: text/html\n\n";
PutHeader("Column Change");
my %desc; my %desc;
foreach my $i (@masterlist) { foreach my $i (@masterlist) {
...@@ -71,12 +72,11 @@ $desc{'summary'} = "Summary (first 60 characters)"; ...@@ -71,12 +72,11 @@ $desc{'summary'} = "Summary (first 60 characters)";
$desc{'summaryfull'} = "Full Summary"; $desc{'summaryfull'} = "Full Summary";
print "\n";
print "Check which columns you wish to appear on the list, and then click\n"; print "Check which columns you wish to appear on the list, and then click\n";
print "on submit.\n"; print "on submit.\n";
print "<p>\n"; print "<p>\n";
print "<FORM ACTION=colchange.cgi>\n"; print "<FORM ACTION=\"colchange.cgi\">\n";
print "<INPUT TYPE=HIDDEN NAME=rememberedquery VALUE=$::buffer>\n"; print "<INPUT TYPE=\"HIDDEN\" NAME=\"rememberedquery\" VALUE=\"$::buffer\">\n";
foreach my $i (@masterlist) { foreach my $i (@masterlist) {
my $c; my $c;
...@@ -85,13 +85,13 @@ foreach my $i (@masterlist) { ...@@ -85,13 +85,13 @@ foreach my $i (@masterlist) {
} else { } else {
$c = ''; $c = '';
} }
print "<INPUT TYPE=checkbox NAME=column_$i $c>$desc{$i}<br>\n"; print "<INPUT TYPE=\"checkbox\" NAME=\"column_$i\" $c>$desc{$i}<br>\n";
} }
print "<P>\n"; print "<P>\n";
print "<INPUT TYPE=\"submit\" VALUE=\"Submit\">\n"; print "<INPUT TYPE=\"submit\" VALUE=\"Submit\">\n";
print "</FORM>\n"; print "</FORM>\n";
print "<FORM ACTION=colchange.cgi>\n"; print "<FORM ACTION=\"colchange.cgi\">\n";
print "<INPUT TYPE=HIDDEN NAME=rememberedquery VALUE=$::buffer>\n"; print "<INPUT TYPE=\"HIDDEN\" NAME=\"rememberedquery\" VALUE=\"$::buffer\">\n";
print "<INPUT TYPE=HIDDEN NAME=resetit VALUE=1>\n"; print "<INPUT TYPE=\"HIDDEN\" NAME=\"resetit\" VALUE=\"1\">\n";
print "<INPUT TYPE=\"submit\" VALUE=\"Reset to Bugzilla default\">\n"; print "<INPUT TYPE=\"submit\" VALUE=\"Reset to Bugzilla default\">\n";
print "</FORM>\n"; print "</FORM>\n";
doeditowners.cgi
View file @ 0ca30382
...@@ -68,5 +68,5 @@ foreach my $update (@updates) { ...@@ -68,5 +68,5 @@ foreach my $update (@updates) {
} }
print "OK, done.<p>\n"; print "OK, done.<p>\n";
print "<a href=editowners.cgi>Edit the owners some more.</a><p>\n"; print "<A HREF=\"editowners.cgi\">Edit the owners some more.</A>\n<P>\n";
print "<a href=query.cgi>Go back to the query page.</a>\n"; print "<A HREF=\"query.cgi\">Go back to the query page.</A>\n";
doeditparams.cgi
View file @ 0ca30382
...@@ -70,6 +70,6 @@ foreach my $i (@::param_list) { ...@@ -70,6 +70,6 @@ foreach my $i (@::param_list) {
WriteParams(); WriteParams();
print "OK, done.<p>\n"; print "OK, done.<p>\n";
print "<a href=editparams.cgi>Edit the params some more.</a><p>\n"; print "<A HREF=\"editparams.cgi\">Edit the params some more.</A>\n<P>\n";
print "<a href=query.cgi>Go back to the query page.</a>\n"; print "<A HREF=\"query.cgi\">Go back to the query page.</A>\n";
editowners.cgi
View file @ 0ca30382
...@@ -44,9 +44,9 @@ PutHeader("Edit Component Owners"); ...@@ -44,9 +44,9 @@ PutHeader("Edit Component Owners");
print "This lets you edit the owners of the program components of bugzilla.\n"; print "This lets you edit the owners of the program components of bugzilla.\n";
print "<form method=post action=doeditowners.cgi><table>\n"; print "<FORM METHOD=\"POST\" ACTION=\"doeditowners.cgi\">\n<TABLE>\n";
my $rowbreak = "<tr><td colspan=2><hr></td></tr>"; my $rowbreak = "<TR><TD COLSPAN=\"2\"><HR></TD></TR>";
SendSQL("select program, value, initialowner from components order by program, value"); SendSQL("select program, value, initialowner from components order by program, value");
...@@ -56,17 +56,17 @@ my $curProgram = ""; ...@@ -56,17 +56,17 @@ my $curProgram = "";
while (@line = FetchSQLData()) { while (@line = FetchSQLData()) {
if ($line[0] ne $curProgram) { if ($line[0] ne $curProgram) {
print $rowbreak; print $rowbreak;
print "<tr><th align=right valign=top>$line[0]:</th><td></td></tr>\n"; print "<TR><TH ALIGN=\"RIGHT\" VALIGN=\"TOP\">$line[0]:</TH><TD></TD></TR>\n";
$curProgram = $line[0]; $curProgram = $line[0];
} }
print "<tr><td valign = top>$line[1]</td><td><input size=80 "; print "<TR><TD VALIGN=\"TOP\">$line[1]</TD><TD><INPUT SIZE=\"80\" ";
print "name=\"$line[0]_$line[1]\" value=\"$line[2]\"></td></tr>\n"; print "name=\"$line[0]_$line[1]\" value=\"$line[2]\"></td></tr>\n";
} }
print "</table>\n"; print "</table>\n";
print "<input type=submit value=\"Submit changes\">\n"; print "<INPUT TYPE=\"submit\" VALUE=\"Submit changes\">\n";
print "</form>\n"; print "</form>\n";
print "<p><a href=query.cgi>Skip all this, and go back to the query page</a>\n"; print "<P><A HREF=\"query.cgi\">Skip all this, and go back to the query page</A>\n";
editparams.cgi
View file @ 0ca30382
...@@ -49,23 +49,23 @@ print "Be careful!\n"; ...@@ -49,23 +49,23 @@ print "Be careful!\n";
print "<p>\n"; print "<p>\n";
print "Any item you check Reset on will get reset to its default value.\n"; print "Any item you check Reset on will get reset to its default value.\n";
print "<form method=post action=doeditparams.cgi><table>\n"; print "<FORM METHOD=\"POST\" ACTION=\"doeditparams.cgi\">\n<TABLE>\n";
my $rowbreak = "<tr><td colspan=2><hr></td></tr>"; my $rowbreak = "<TR><TD COLSPAN=\"2\"><HR></TD></TR>";
print $rowbreak; print $rowbreak;
foreach my $i (@::param_list) { foreach my $i (@::param_list) {
print "<tr><th align=right valign=top>$i:</th><td>$::param_desc{$i}</td></tr>\n"; print "<TR><TH ALIGN=\"RIGHT\" VALIGN=\"TOP\">$i:</TH><TD>$::param_desc{$i}</TD></TR>\n";
print "<tr><td valign=top><input type=checkbox name=reset-$i>Reset</td><td>\n"; print "<TR><TD VALIGN=\"TOP\"><INPUT TYPE=\"checkbox\" NAME=\"reset-$i\">Reset</TD><TD>\n";
my $value = Param($i); my $value = Param($i);
SWITCH: for ($::param_type{$i}) { SWITCH: for ($::param_type{$i}) {
/^t$/ && do { /^t$/ && do {
print "<input size=80 name=$i value=\"" . print "<INPUT SIZE=\"80\" NAME=\"$i\" VALUE=\"" .
value_quote($value) . '">\n'; value_quote($value) . '">\n';
last SWITCH; last SWITCH;
}; };
/^l$/ && do { /^l$/ && do {
print "<textarea wrap=hard name=$i rows=10 cols=80>" . print "<TEXTAREA WRAP=\"HARD\" NAME=\"$i\" ROWS=\"10\" COLS=\"80\">" .
value_quote($value) . "</textarea>\n"; value_quote($value) . "</textarea>\n";
last SWITCH; last SWITCH;
}; };
...@@ -79,18 +79,18 @@ foreach my $i (@::param_list) { ...@@ -79,18 +79,18 @@ foreach my $i (@::param_list) {
$on = ""; $on = "";
$off = "checked"; $off = "checked";
} }
print "<input type=radio name=$i value=1 $on>On\n"; print "<INPUT TYPE=\"radio\" NAME=\"$i\" VALUE=\"1\" $on>On\n";
print "<input type=radio name=$i value=0 $off>Off\n"; print "<INPUT TYPE=\"radio\" NAME=\"$i\" VALUE=\"0\" $off>Off\n";
last SWITCH; last SWITCH;
}; };
# DEFAULT # DEFAULT
print "<font color=red><blink>Unknown param type $::param_type{$i}!!!</blink></font>\n"; print "<FONT COLOR=\"red\"><BLINK>Unknown param type $::param_type{$i}!!!</BLINK></FONT>\n";
} }
print "</td></tr>\n"; print "</td></tr>\n";
print $rowbreak; print $rowbreak;
} }
print "<tr><th align=right valign=top>version:</th><td> print "<TR><TH ALIGN=\"RIGHT\" VALIGN=\"TOP\">version:</TH><TD>
What version of Bugzilla this is. This can't be modified here, but What version of Bugzilla this is. This can't be modified here, but
<tt>%version%</tt> can be used as a parameter in places that understand <tt>%version%</tt> can be used as a parameter in places that understand
such parameters</td></tr> such parameters</td></tr>
...@@ -98,9 +98,9 @@ such parameters</td></tr> ...@@ -98,9 +98,9 @@ such parameters</td></tr>
print "</table>\n"; print "</table>\n";
print "<input type=reset value=\"Reset form\"><br>\n"; print "<INPUT TYPE=\"reset\" VALUE=\"Reset form\"><BR>\n";
print "<input type=submit value=\"Submit changes\">\n"; print "<INPUT TYPE=\"submit\" VALUE=\"Submit changes\">\n";
print "</form>\n"; print "</form>\n";
print "<p><a href=query.cgi>Skip all this, and go back to the query page</a>\n"; print "<P><A HREF=\"query.cgi\">Skip all this, and go back to the query page</A>\n";
enter_bug.cgi
View file @ 0ca30382
...@@ -43,9 +43,9 @@ if (!defined $::FORM{'product'}) { ...@@ -43,9 +43,9 @@ if (!defined $::FORM{'product'}) {
print "a bug.</H2>\n"; print "a bug.</H2>\n";
print "<table>"; print "<table>";
foreach my $p (sort (@prodlist)) { foreach my $p (sort (@prodlist)) {
print "<tr><th align=right valign=top><a href=\"enter_bug.cgi?product=" . url_quote($p) . "\"&$::buffer>$p</a>:</th>\n"; print "<TR><TH ALIGN=\"RIGHT\" VALIGN=\"TOP\"><A HREF=\"enter_bug.cgi?product=" . url_quote($p) . "\"&$::buffer>$p</A>:</TH>\n";
if (defined $::proddesc{$p}) { if (defined $::proddesc{$p}) {
print "<td valign=top>$::proddesc{$p}</td>\n"; print "<TD VALIGN=\"TOP\">$::proddesc{$p}</TD>\n";
} }
print "</tr>"; print "</tr>";
} }
...@@ -55,7 +55,7 @@ if (!defined $::FORM{'product'}) { ...@@ -55,7 +55,7 @@ if (!defined $::FORM{'product'}) {
$::FORM{'product'} = $prodlist[0]; $::FORM{'product'} = $prodlist[0];
} }
my $product = $::FORM{'product'}; my $product = url_decode($::FORM{'product'});
confirm_login(); confirm_login();
...@@ -149,7 +149,7 @@ GetVersionTable(); ...@@ -149,7 +149,7 @@ GetVersionTable();
my $assign_element = GeneratePersonInput('assigned_to', 1, my $assign_element = GeneratePersonInput('assigned_to', 1,
formvalue('assigned_to')); formvalue('assigned_to'));
my $cc_element = GeneratePeopleInput('cc', formvalue('cc')); my $cc_element = GeneratePeopleInput('cc', 45, formvalue('cc'));
my $priority_popup = make_popup('priority', \@::legal_priority, my $priority_popup = make_popup('priority', \@::legal_priority,
......
post_bug.cgi
View file @ 0ca30382
...@@ -18,6 +18,7 @@ ...@@ -18,6 +18,7 @@
# Netscape Communications Corporation. All Rights Reserved. # Netscape Communications Corporation. All Rights Reserved.
# #
# Contributor(s): Terry Weissman <terry@mozilla.org> # Contributor(s): Terry Weissman <terry@mozilla.org>
# Andrew Anderson <andrew@redhat.com>
use diagnostics; use diagnostics;
...@@ -34,17 +35,19 @@ $zz = $zz . $zz; ...@@ -34,17 +35,19 @@ $zz = $zz . $zz;
confirm_login(); confirm_login();
print "Set-Cookie: PLATFORM=$::FORM{'product'} ; path=/ ; expires=Sun, 30-Jun-2029 00:00:00 GMT\n"; my $platform = url_quote($::FORM{'product'});
print "Set-Cookie: VERSION-$::FORM{'product'}=$::FORM{'version'} ; path=/ ; expires=Sun, 30-Jun-2029 00:00:00 GMT\n"; my $version = url_quote($::FORM{'version'});
print "Set-Cookie: PLATFORM=$platform ; path=/ ; expires=Sun, 30-Jun-2029 00:00:00 GMT\n";
print "Set-Cookie: VERSION-$platform=$version ; path=/ ; expires=Sun, 30-Jun-2029 00:00:00 GMT\n";
print "Content-type: text/html\n\n"; print "Content-type: text/html\n\n";
if (defined $::FORM{'maketemplate'}) { if (defined $::FORM{'maketemplate'}) {
print "<TITLE>Bookmarks are your friend.</TITLE>\n"; PutHeader("Bookmarks are your friend.", "Template constructed.");
print "<H1>Template constructed.</H1>\n";
my $url = "enter_bug.cgi?$::buffer"; my $url = "enter_bug.cgi?$::buffer";
print "If you put a bookmark <a href=\"$url\">to this link</a>, it will\n"; print "If you put a bookmark <A HREF=\"$url\">to this link</A>, it will\n";
print "bring up the submit-a-new-bug page with the fields initialized\n"; print "bring up the submit-a-new-bug page with the fields initialized\n";
print "as you've requested.\n"; print "as you've requested.\n";
exit; exit;
...@@ -118,6 +121,8 @@ foreach my $person (keys %ccids) { ...@@ -118,6 +121,8 @@ foreach my $person (keys %ccids) {
print "<H2>Changes Submitted</H2>\n"; print "<H2>Changes Submitted</H2>\n";
print "<A HREF=\"show_bug.cgi?id=$id\">Show BUG# $id</A>\n"; print "<A HREF=\"show_bug.cgi?id=$id\">Show BUG# $id</A>\n";
print "<BR><A HREF=\"query.cgi\">Back To Query Page</A>\n"; print "<BR><A HREF=\"query.cgi\">Back To Query Page</A>\n";
print "<BR><A HREF=\"enter_bug.cgi?product=" . url_quote($::FORM{'product'}). "\">Enter a new bug</A>\n";
system("./processmail $id < /dev/null > /dev/null 2> /dev/null &"); system("./processmail $id < /dev/null > /dev/null 2> /dev/null &");
exit; exit;
process_bug.cgi
View file @ 0ca30382
...@@ -37,7 +37,7 @@ print "Content-type: text/html\n\n"; ...@@ -37,7 +37,7 @@ print "Content-type: text/html\n\n";
GetVersionTable(); GetVersionTable();
if ($::FORM{'product'} ne $::dontchange) { if ($::FORM{'product'} ne $::dontchange) {
my $prod = $::FORM{'product'}; my $prod = url_decode($::FORM{'product'});
my $vok = lsearch($::versions{$prod}, $::FORM{'version'}) >= 0; my $vok = lsearch($::versions{$prod}, $::FORM{'version'}) >= 0;
my $cok = lsearch($::components{$prod}, $::FORM{'component'}) >= 0; my $cok = lsearch($::components{$prod}, $::FORM{'component'}) >= 0;
if (!$vok || !$cok) { if (!$vok || !$cok) {
...@@ -49,26 +49,26 @@ if ($::FORM{'product'} ne $::dontchange) { ...@@ -49,26 +49,26 @@ if ($::FORM{'product'} ne $::dontchange) {
print "<form>\n"; print "<form>\n";
print "<table>\n"; print "<table>\n";
print "<tr>\n"; print "<tr>\n";
print "<td align=right><b>Product:</b></td>\n"; print "<td align=\"right\"><b>Product:</b></td>\n";
print "<td>$prod</td>\n"; print "<td>$prod</td>\n";
print "</tr><tr>\n"; print "</tr><tr>\n";
print "<td align=right><b>Version:</b></td>\n"; print "<td align=\"right\"><b>Version:</b></td>\n";
print "<td>" . Version_element($::FORM{'version'}, $prod) . "</td>\n"; print "<td>" . Version_element($::FORM{'version'}, $prod) . "</td>\n";
print "</tr><tr>\n"; print "</tr><tr>\n";
print "<td align=right><b>Component:</b></td>\n"; print "<td align=\"right\"><b>Component:</b></td>\n";
print "<td>" . Component_element($::FORM{'component'}, $prod) . "</td>\n"; print "<td>" . Component_element($::FORM{'component'}, $prod) . "</td>\n";
print "</tr>\n"; print "</tr>\n";
print "</table>\n"; print "</table>\n";
foreach my $i (keys %::FORM) { foreach my $i (keys %::FORM) {
if ($i ne 'version' && $i ne 'component') { if ($i ne 'version' && $i ne 'component') {
print "<input type=hidden name=$i value=\"" . print "<input type=\"hidden\" name=\"$i\" value=\"" .
value_quote($::FORM{$i}) . "\">\n"; value_quote($::FORM{$i}) . "\">\n";
} }
} }
print "<input type=submit value=Commit>\n"; print "<input type=\"submit\" value=\"Commit\">\n";
print "</form>\n"; print "</form>\n";
print "</hr>\n"; print "</hr>\n";
print "<a href=query.cgi>Cancel all this and go back to the query page.</a>\n"; print "<A HREF=\"query.cgi\">Cancel all this and go back to the query page.</A>\n";
exit; exit;
} }
} }
...@@ -89,11 +89,6 @@ if (!defined $::FORM{'who'}) { ...@@ -89,11 +89,6 @@ if (!defined $::FORM{'who'}) {
$::FORM{'who'} = $::COOKIE{'Bugzilla_login'}; $::FORM{'who'} = $::COOKIE{'Bugzilla_login'};
} }
print "<TITLE>Update Bug " . join(" ", @idlist) . "</TITLE>\n";
if (defined $::FORM{'id'}) {
navigation_header();
}
print "<HR>\n";
$::query = "update bugs\nset"; $::query = "update bugs\nset";
$::comma = ""; $::comma = "";
umask(0); umask(0);
...@@ -119,6 +114,7 @@ sub ChangeResolution { ...@@ -119,6 +114,7 @@ sub ChangeResolution {
} }
} }
ConnectToDatabase();
foreach my $field ("rep_platform", "priority", "bug_severity", "url", foreach my $field ("rep_platform", "priority", "bug_severity", "url",
"summary", "component", "bug_file_loc", "short_desc", "summary", "component", "bug_file_loc", "short_desc",
...@@ -126,15 +122,11 @@ foreach my $field ("rep_platform", "priority", "bug_severity", "url", ...@@ -126,15 +122,11 @@ foreach my $field ("rep_platform", "priority", "bug_severity", "url",
if (defined $::FORM{$field}) { if (defined $::FORM{$field}) {
if ($::FORM{$field} ne $::dontchange) { if ($::FORM{$field} ne $::dontchange) {
DoComma(); DoComma();
$::query .= "$field = " . SqlQuote($::FORM{$field}); $::query .= "$field = " . SqlQuote(url_decode($::FORM{$field}));
} }
} }
} }
ConnectToDatabase();
SWITCH: for ($::FORM{'knob'}) { SWITCH: for ($::FORM{'knob'}) {
/^none$/ && do { /^none$/ && do {
last SWITCH; last SWITCH;
...@@ -177,6 +169,7 @@ SWITCH: for ($::FORM{'knob'}) { ...@@ -177,6 +169,7 @@ SWITCH: for ($::FORM{'knob'}) {
}; };
/^reopen$/ && do { /^reopen$/ && do {
ChangeStatus('REOPENED'); ChangeStatus('REOPENED');
ChangeResolution('');
last SWITCH; last SWITCH;
}; };
/^verify$/ && do { /^verify$/ && do {
...@@ -197,7 +190,8 @@ SWITCH: for ($::FORM{'knob'}) { ...@@ -197,7 +190,8 @@ SWITCH: for ($::FORM{'knob'}) {
exit; exit;
} }
if ($::FORM{'dup_id'} == $::FORM{'id'}) { if ($::FORM{'dup_id'} == $::FORM{'id'}) {
print "Nice try. But it doesn't really make sense to mark a\n"; PutHeader("Nice try.");
print "But it doesn't really make sense to mark a\n";
print "bug as a duplicate of itself, does it?\n"; print "bug as a duplicate of itself, does it?\n";
exit; exit;
} }
...@@ -213,6 +207,7 @@ SWITCH: for ($::FORM{'knob'}) { ...@@ -213,6 +207,7 @@ SWITCH: for ($::FORM{'knob'}) {
if ($#idlist < 0) { if ($#idlist < 0) {
PutHeader("Nothing to modify");
print "You apparently didn't choose any bugs to modify.\n"; print "You apparently didn't choose any bugs to modify.\n";
print "<p>Click <b>Back</b> and try again.\n"; print "<p>Click <b>Back</b> and try again.\n";
exit; exit;
...@@ -231,7 +226,7 @@ my $basequery = $::query; ...@@ -231,7 +226,7 @@ my $basequery = $::query;
sub SnapShotBug { sub SnapShotBug {
my ($id) = (@_); my ($id) = (@_);
SendSQL("select " . join(',', @::log_columns) . SendSQL("select " . join(',', @::log_columns) .
" from bugs where bug_id = $id"); " from bugs where bug_id = '" . $id . "'");
return FetchSQLData(); return FetchSQLData();
} }
...@@ -240,7 +235,7 @@ foreach my $id (@idlist) { ...@@ -240,7 +235,7 @@ foreach my $id (@idlist) {
SendSQL("lock tables bugs write, bugs_activity write, cc write, profiles write"); SendSQL("lock tables bugs write, bugs_activity write, cc write, profiles write");
my @oldvalues = SnapShotBug($id); my @oldvalues = SnapShotBug($id);
my $query = "$basequery\nwhere bug_id = $id"; my $query = "$basequery\nwhere bug_id = '" . $id . "'";
# print "<PRE>$query</PRE>\n"; # print "<PRE>$query</PRE>\n";
...@@ -261,7 +256,7 @@ foreach my $id (@idlist) { ...@@ -261,7 +256,7 @@ foreach my $id (@idlist) {
} }
} }
SendSQL("delete from cc where bug_id = $id"); SendSQL("delete from cc where bug_id = '" . $id . "'");
foreach my $ccid (keys %ccids) { foreach my $ccid (keys %ccids) {
SendSQL("insert into cc (bug_id, who) values ($id, $ccid)"); SendSQL("insert into cc (bug_id, who) values ($id, $ccid)");
} }
...@@ -276,7 +271,8 @@ foreach my $id (@idlist) { ...@@ -276,7 +271,8 @@ foreach my $id (@idlist) {
if ($old ne $new) { if ($old ne $new) {
if (!defined $whoid) { if (!defined $whoid) {
$whoid = DBNameToIdAndCheck($::FORM{'who'}); $whoid = DBNameToIdAndCheck($::FORM{'who'});
SendSQL("select delta_ts from bugs where bug_id = $id"); $query = "select delta_ts from bugs where bug_id = '" . $id . "'";
SendSQL($query);
$timestamp = FetchOneColumn(); $timestamp = FetchOneColumn();
} }
if ($col eq 'assigned_to') { if ($col eq 'assigned_to') {
...@@ -287,13 +283,21 @@ foreach my $id (@idlist) { ...@@ -287,13 +283,21 @@ foreach my $id (@idlist) {
$old = SqlQuote($old); $old = SqlQuote($old);
$new = SqlQuote($new); $new = SqlQuote($new);
my $q = "insert into bugs_activity (bug_id,who,when,field,oldvalue,newvalue) values ($id,$whoid,$timestamp,$col,$old,$new)"; my $q = "insert into bugs_activity (bug_id,who,when,field,oldvalue,newvalue) values ($id,$whoid,$timestamp,$col,$old,$new)";
# puts "<pre>$q</pre>" # print "<pre>$q</pre>";
SendSQL($q); SendSQL($q);
} }
} }
print "<TABLE BORDER=1><TD><H1>Changes Submitted</H1>\n";
print "<TD><A HREF=\"show_bug.cgi?id=$id\">Back To BUG# $id</A></TABLE>\n"; PutHeader("Changes submitted for bug $::FORM{'id'}",
"Changes Submitted", $::FORM{'id'});
if (defined $::FORM{'id'}) {
navigation_header();
}
print "<HR>\n<P>\n";
print "<A HREF=\"show_bug.cgi?id=$id\">Back To BUG# $id</A>\n";
print "<BR><A HREF=\"query.cgi\">Back To Query Page</A>\n";
print "<BR><A HREF=\"enter_bug.cgi\">Enter a new bug</A>\n";
SendSQL("unlock tables"); SendSQL("unlock tables");
......
query.cgi
View file @ 0ca30382
...@@ -99,8 +99,8 @@ print "Set-Cookie: BUGLIST= ...@@ -99,8 +99,8 @@ print "Set-Cookie: BUGLIST=
Content-type: text/html\n\n"; Content-type: text/html\n\n";
GetVersionTable(); GetVersionTable();
my $who = GeneratePeopleInput("assigned_to", $default{"assigned_to"}); my $who = GeneratePeopleInput("assigned_to", 45, $default{"assigned_to"});
my $reporter = GeneratePeopleInput("reporter", $default{"reporter"}); my $reporter = GeneratePeopleInput("reporter", 45, $default{"reporter"});
# Muck the "legal product" list so that the default one is always first (and # Muck the "legal product" list so that the default one is always first (and
...@@ -118,97 +118,102 @@ PutHeader("Bugzilla Query Page", "Query Page"); ...@@ -118,97 +118,102 @@ PutHeader("Bugzilla Query Page", "Query Page");
push @::legal_resolution, "---"; # Oy, what a hack. push @::legal_resolution, "---"; # Oy, what a hack.
print " print "
<FORM NAME=queryForm METHOD=GET ACTION=\"buglist.cgi\"> <FORM NAME=\"queryForm\" METHOD=\"GET\" ACTION=\"buglist.cgi\">
<table> <table>
<tr> <tr>
<th align=left><A HREF=\"bug_status.html\">Status</a>:</th> <th align=\"left\"><A HREF=\"bug_status.html\">Status</a>:</th>
<th align=left><A HREF=\"bug_status.html\">Resolution</a>:</th> <th align=\"left\"><A HREF=\"bug_status.html\">Resolution</a>:</th>
<th align=left><A HREF=\"bug_status.html#rep_platform\">Platform</a>:</th> <th align=\"left\"><A HREF=\"bug_status.html#rep_platform\">Platform</a>:</th>
<th align=left><A HREF=\"bug_status.html#priority\">Priority</a>:</th> <th align=\"left\"><A HREF=\"bug_status.html#priority\">Priority</a>:</th>
<th align=left><A HREF=\"bug_status.html#severity\">Severity</a>:</th> <th align=\"left\"><A HREF=\"bug_status.html#severity\">Severity</a>:</th>
</tr> </tr>
<tr> <tr>
<td align=left valign=top> <td align=\"left\" valign=\"top\">
<SELECT NAME=\"bug_status\" MULTIPLE SIZE=7> <SELECT NAME=\"bug_status\" MULTIPLE SIZE=\"7\">
@{[make_options(\@::legal_bug_status, $default{'bug_status'}, $type{'bug_status'})]} @{[make_options(\@::legal_bug_status, $default{'bug_status'}, $type{'bug_status'})]}
</SELECT> </SELECT><P>
</td> </td>
<td align=left valign=top> <td align=\"left\" valign=\"top\">
<SELECT NAME=\"resolution\" MULTIPLE SIZE=7> <SELECT NAME=\"resolution\" MULTIPLE SIZE=\"7\">
@{[make_options(\@::legal_resolution, $default{'resolution'}, $type{'resolution'})]} @{[make_options(\@::legal_resolution, $default{'resolution'}, $type{'resolution'})]}
</SELECT> </SELECT><P>
</td> </td>
<td align=left valign=top> <td align=\"left\" valign=\"top\">
<SELECT NAME=\"rep_platform\" MULTIPLE SIZE=7> <SELECT NAME=\"rep_platform\" MULTIPLE SIZE=\"7\">
@{[make_options(\@::legal_platform, $default{'rep_platform'}, $type{'rep_platform'})]} @{[make_options(\@::legal_platform, $default{'rep_platform'}, $type{'rep_platform'})]}
</SELECT> </SELECT><P>
</td> </td>
<td align=left valign=top> <td align=\"left\" valign=\"top\">
<SELECT NAME=\"priority\" MULTIPLE SIZE=7> <SELECT NAME=\"priority\" MULTIPLE SIZE=\"7\">
@{[make_options(\@::legal_priority, $default{'priority'}, $type{'priority'})]} @{[make_options(\@::legal_priority, $default{'priority'}, $type{'priority'})]}
</SELECT> </SELECT><P>
</td> </td>
<td align=left valign=top> <td align=\"left\" valign=\"top\">
<SELECT NAME=\"bug_severity\" MULTIPLE SIZE=7> <SELECT NAME=\"bug_severity\" MULTIPLE SIZE=\"7\">
@{[make_options(\@::legal_severity, $default{'bug_severity'}, $type{'bug_severity'})]} @{[make_options(\@::legal_severity, $default{'bug_severity'}, $type{'bug_severity'})]}
</SELECT> </SELECT><P>
</tr> </tr>
</table> </table>
<p> <p>
<TABLE> <TABLE>
<TR><TD ALIGN=RIGHT><B><A HREF=\"bug_status.html#assigned_to\">Assigned To:</a></B><TD>$who <TR>
<TD ALIGN=\"RIGHT\">
<A HREF=\"bug_status.html#assigned_to\"><B>Assigned To:</B></A>
<TD>$who
<p> <p>
<TR><TD ALIGN=RIGHT><B>Reporter:</B><TD>$reporter <TR>
<TD ALIGN=\"RIGHT\">
<A HREF=\"bug_status.html#reporter\"><B>Reporter:</B></A>
<TD>$reporter
</TABLE> </TABLE>
<NOBR>Changed in the last <INPUT NAME=changedin SIZE=2> days.</NOBR> <NOBR>Changed in the last <INPUT NAME=\"changedin\" SIZE=\"2\"> days.</NOBR>
<P> <P>
<table> <table>
<tr> <tr>
<TH ALIGN=LEFT>Program:</th> <TH ALIGN=\"LEFT\">Program:</th>
<TH ALIGN=LEFT>Version:</th> <TH ALIGN=\"LEFT\">Version:</th>
<TH ALIGN=LEFT>Component:</th> <TH ALIGN=\"LEFT\">Component:</th>
</tr> </tr>
<tr> <tr>
<td align=left valign=top> <td align=\"left\" valign=\"top\">
<SELECT NAME=\"product\" MULTIPLE SIZE=5> <SELECT NAME=\"product\" MULTIPLE SIZE=\"5\">
@{[make_options(\@::legal_product, $default{'product'}, $type{'product'})]} @{[make_options(\@::legal_product, url_decode($default{'product'}), $type{'product'})]}
</SELECT> </SELECT><P>
</td> </td>
<td align=left valign=top> <td align=\"left\" valign=\"top\">
<SELECT NAME=\"version\" MULTIPLE SIZE=5> <SELECT NAME=\"version\" MULTIPLE SIZE=\"5\">
@{[make_options(\@::legal_versions, $default{'version'}, $type{'version'})]} @{[make_options(\@::legal_versions, $default{'version'}, $type{'version'})]}
</SELECT> </SELECT><P>
</td> </td>
<td align=left valign=top> <td align=\"left\" valign=\"top\">
<SELECT NAME=\"component\" MULTIPLE SIZE=5> <SELECT NAME=\"component\" MULTIPLE SIZE=\"5\">
@{[make_options(\@::legal_components, $default{'component'}, $type{'component'})]} @{[make_options(\@::legal_components, $default{'component'}, $type{'component'})]}
</SELECT> </SELECT><P>
</td> </td>
</tr> </tr>
</table> </table>
<table border=0> <table border=\"0\">
<tr> <tr>
<td align=right>Summary:</td> <td align=\"right\">Summary:</td>
<td><input name=short_desc size=30></td> <td><input name=\"short_desc\" size=\"30\"></td>
<td><input type=radio name=short_desc_type value=substr checked>Substring</td> <td><input type=\"radio\" name=\"short_desc_type\" value=\"substr\" checked>Substring</td>
<td><input type=radio name=short_desc_type value=regexp>Regexp</td> <td><input type=\"radio\" name=\"short_desc_type\" value=\"regexp\">Regexp</td>
</tr> </tr>
<tr> <tr>
<td align=right>Description:</td> <td align=\"right\">Description:</td>
<td><input name=long_desc size=30></td> <td><input name=\"long_desc\" size=\"30\"></td>
<td><input type=radio name=long_desc_type value=substr checked>Substring</td> <td><input type=\"radio\" name=\"long_desc_type\" value=\"substr\" checked>Substring</td>
<td><input type=radio name=long_desc_type value=regexp>Regexp</td> <td><input type=\"radio\" name=\"long_desc_type\" value=\"regexp\">Regexp</td>
</tr> </tr>
</table> </table>
<p> <p>
...@@ -216,27 +221,27 @@ print " ...@@ -216,27 +221,27 @@ print "
<BR> <BR>
<INPUT TYPE=radio NAME=cmdtype VALUE=doit CHECKED> Run this query <INPUT TYPE=\"radio\" NAME=\"cmdtype\" VALUE=\"doit\" CHECKED> Run this query
<BR> <BR>
"; ";
if ($namelist ne "") { if ($namelist ne "") {
print " print "
<table cellspacing=0 cellpadding=0><tr> <table cellspacing=\"0\" cellpadding=\"0\"><tr>
<td><INPUT TYPE=radio NAME=cmdtype VALUE=editnamed> Load the remembered query:</td> <td><INPUT TYPE=\"radio\" NAME=\"cmdtype\" VALUE=\"editnamed\"> Load the remembered query:</td>
<td rowspan=3><select name=namedcmd>$namelist</select> <td rowspan=\"3\"><select name=\"namedcmd\">$namelist</select>
</tr><tr> </tr><tr>
<td><INPUT TYPE=radio NAME=cmdtype VALUE=runnamed> Run the remembered query:</td> <td><INPUT TYPE=\"radio\" NAME=\"cmdtype\" VALUE=\"runnamed\"> Run the remembered query:</td>
</tr><tr> </tr><tr>
<td><INPUT TYPE=radio NAME=cmdtype VALUE=forgetnamed> Forget the remembered query:</td> <td><INPUT TYPE=\"radio\" NAME=\"cmdtype\" VALUE=\"forgetnamed\"> Forget the remembered query:</td>
</tr></table>" </tr></table>"
} }
print " print "
<INPUT TYPE=radio NAME=cmdtype VALUE=asdefault> Remember this as the default query <INPUT TYPE=\"radio\" NAME=\"cmdtype\" VALUE=\"asdefault\"> Remember this as the default query
<BR> <BR>
<INPUT TYPE=radio NAME=cmdtype VALUE=asnamed> Remember this query, and name it: <INPUT TYPE=\"radio\" NAME=\"cmdtype\" VALUE=\"asnamed\"> Remember this query, and name it:
<INPUT TYPE=text NAME=newqueryname> <INPUT TYPE=\"text\" NAME=\"newqueryname\">
<BR> <BR>
<NOBR><B>Sort By:</B> <NOBR><B>Sort By:</B>
...@@ -247,7 +252,7 @@ print " ...@@ -247,7 +252,7 @@ print "
</SELECT></NOBR> </SELECT></NOBR>
<INPUT TYPE=\"submit\" VALUE=\"Submit\"> <INPUT TYPE=\"submit\" VALUE=\"Submit\">
<INPUT TYPE=\"reset\" VALUE=\"Reset back to the default query\"> <INPUT TYPE=\"reset\" VALUE=\"Reset back to the default query\">
<INPUT TYPE=hidden name=form_name VALUE=query> <INPUT TYPE=\"hidden\" name=\"form_name\" VALUE=\"query\">
<BR>Give me a <A HREF=\"help.html\">clue</A> about how to use this form. <BR>Give me a <A HREF=\"help.html\">clue</A> about how to use this form.
</CENTER> </CENTER>
</FORM> </FORM>
...@@ -257,14 +262,14 @@ print " ...@@ -257,14 +262,14 @@ print "
if (defined $::COOKIE{"Bugzilla_login"}) { if (defined $::COOKIE{"Bugzilla_login"}) {
if ($::COOKIE{"Bugzilla_login"} eq Param("maintainer")) { if ($::COOKIE{"Bugzilla_login"} eq Param("maintainer")) {
print "<a href=editparams.cgi>Edit Bugzilla operating parameters</a><br>\n"; print "<a href=\"editparams.cgi\">Edit Bugzilla operating parameters</a><br>\n";
print "<a href=editowners.cgi>Edit Bugzilla component owners</a><br>\n"; print "<a href=\"editowners.cgi\">Edit Bugzilla component owners</a><br>\n";
} }
print "<a href=relogin.cgi>Log in as someone besides <b>$::COOKIE{'Bugzilla_login'}</b></a><br>\n"; print "<a href=\"relogin.cgi\">Log in as someone besides <b>$::COOKIE{'Bugzilla_login'}</b></a><br>\n";
} }
print "<a href=changepassword.cgi>Change your password.</a><br>\n"; print "<a href=\"changepassword.cgi\">Change your password.</a><br>\n";
print "<a href=\"enter_bug.cgi\">Create a new bug.</a><br>\n"; print "<a href=\"enter_bug.cgi\">Enter a new bug.</a><br>\n";
print "<a href=\"reports.cgi\">Bug reports</a><br>\n"; print "<a href=\"reports.cgi\">Bug reports.</a><br>\n";
......
relogin.cgi
View file @ 0ca30382
...@@ -30,11 +30,13 @@ Set-Cookie: Bugzilla_logincookie= ; path=/; expires=Sun, 30-Jun-80 00:00:00 GMT ...@@ -30,11 +30,13 @@ Set-Cookie: Bugzilla_logincookie= ; path=/; expires=Sun, 30-Jun-80 00:00:00 GMT
Set-Cookie: Bugzilla_password= ; path=/; expires=Sun, 30-Jun-80 00:00:00 GMT Set-Cookie: Bugzilla_password= ; path=/; expires=Sun, 30-Jun-80 00:00:00 GMT
Content-type: text/html Content-type: text/html
<H1>Your login has been forgotten.</H1> ";
PutHeader("Your login has been forgotten");
print "
The cookie that was remembering your login is now gone. The next time you The cookie that was remembering your login is now gone. The next time you
do an action that requires a login, you will be prompted for it. do an action that requires a login, you will be prompted for it.
<p> <p>
<a href=query.cgi>Back to the query page.</a> <A HREF=\"query.cgi\">Back to the query page.</A>
"; ";
exit; exit;
......
reports.cgi
View file @ 0ca30382
...@@ -156,11 +156,12 @@ FIN ...@@ -156,11 +156,12 @@ FIN
sub most_doomed sub most_doomed
{ {
my $when = localtime (time); my $when = localtime (time);
my $product = url_decode($::FORM{'product'});
print <<FIN; print <<FIN;
<center> <center>
<h1> <h1>
Bug Report for $::FORM{'product'} Bug Report for $product
</h1> </h1>
$when<p> $when<p>
FIN FIN
...@@ -179,7 +180,7 @@ from bugs, ...@@ -179,7 +180,7 @@ from bugs,
versions projector versions projector
where bugs.assigned_to = assign.userid where bugs.assigned_to = assign.userid
and bugs.reporter = report.userid and bugs.reporter = report.userid
and bugs.product='$::FORM{'product'}' and bugs.product='$product'
and and
( (
bugs.bug_status = 'NEW' or bugs.bug_status = 'NEW' or
...@@ -393,13 +394,13 @@ sub header ...@@ -393,13 +394,13 @@ sub header
FIN FIN
} }
sub show_chart sub show_chart {
{
my $when = localtime (time); my $when = localtime (time);
my $product = url_decode($::FORM{'product'});
if (! is_legal_product ($::FORM{'product'})) if (! is_legal_product($product))
{ {
&die_politely ("Unknown product: $::FORM{'product'}"); &die_politely ("Unknown product: $product");
} }
print <<FIN; print <<FIN;
...@@ -454,7 +455,7 @@ FIN ...@@ -454,7 +455,7 @@ FIN
my %settings = my %settings =
( (
"title" => "Bug Charts for $::FORM{'product'}", "title" => "Bug Charts for $product",
"x_label" => "Dates", "x_label" => "Dates",
"y_label" => "Bug Count", "y_label" => "Bug Count",
"legend_labels" => \@labels, "legend_labels" => \@labels,
...@@ -476,6 +477,7 @@ FIN ...@@ -476,6 +477,7 @@ FIN
sub die_politely sub die_politely
{ {
my $msg = shift; my $msg = shift;
my $product = url_decode($::FORM{'product'});
print <<FIN; print <<FIN;
<p> <p>
...@@ -484,7 +486,7 @@ sub die_politely ...@@ -484,7 +486,7 @@ sub die_politely
<td align=center> <td align=center>
<font color=blue>Sorry, but ...</font> <font color=blue>Sorry, but ...</font>
<p> <p>
There is no graph available for <b>$::FORM{'product'}</b><p> There is no graph available for <b>$product</b><p>
<font size=-1> <font size=-1>
$msg $msg
......
sanitycheck.cgi
View file @ 0ca30382
...@@ -18,6 +18,7 @@ ...@@ -18,6 +18,7 @@
# Netscape Communications Corporation. All Rights Reserved. # Netscape Communications Corporation. All Rights Reserved.
# #
# Contributor(s): Terry Weissman <terry@mozilla.org> # Contributor(s): Terry Weissman <terry@mozilla.org>
# Andrew Anderson <andrew@redhat.com>
use diagnostics; use diagnostics;
use strict; use strict;
...@@ -42,7 +43,7 @@ sub Alert { ...@@ -42,7 +43,7 @@ sub Alert {
sub BugLink { sub BugLink {
my ($id) = (@_); my ($id) = (@_);
return "<a href='show_bug.cgi?id=$id'>$id</a>"; return "<a href=\"show_bug.cgi?id=$id\">$id</a>";
} }
......
show_bug.cgi
View file @ 0ca30382
...@@ -22,16 +22,19 @@ ...@@ -22,16 +22,19 @@
use diagnostics; use diagnostics;
use strict; use strict;
print "Content-type: text/html\n"; use vars @::FORM;
print "\n";
require "CGI.pl"; require "CGI.pl";
if (!defined $::FORM{'id'}) { confirm_login();
print "<H2>Search By Bug Number</H2>\n";
print "<FORM METHOD=GET ACTION=\"show_bug.cgi\">\n"; print "Content-type: text/html\n\n";
if (!defined $::FORM{'id'} || $::FORM{'id'} eq "") {
PutHeader("Search By Bug Number", "Search By Bug Number", "");
print "<FORM METHOD=\"GET\" ACTION=\"show_bug.cgi\">\n";
print "You may find a single bug by entering its bug id here: \n"; print "You may find a single bug by entering its bug id here: \n";
print "<INPUT NAME=id>\n"; print "<INPUT NAME=\"id\">\n";
print "<INPUT TYPE=\"submit\" VALUE=\"Show Me This Bug\">\n"; print "<INPUT TYPE=\"submit\" VALUE=\"Show Me This Bug\">\n";
print "</FORM>\n"; print "</FORM>\n";
exit; exit;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment