The changes to accept positional parameters in XML-RPC meant that sometimes

$params wouldn't just be undef, but actually missing, so validate() was getting @keys where $params should have been. https://bugzilla.mozilla.org/show_bug.cgi?id=577765

The changes to accept positional parameters in XML-RPC meant that sometimes
110186aa · Max Kanat-Alexander · ebe41c4b · 110186aa
Commit 110186aa authored Jul 13, 2010 by Max Kanat-Alexander
Show whitespace changes
Inline Side-by-side

Showing with 5 additions and 0 deletions

Util.pm Bugzilla/WebService/Util.pm +5 -0

No files found.
--- a/Bugzilla/WebService/Util.pm
+++ b/Bugzilla/WebService/Util.pm
@@ -80,6 +80,11 @@ sub _delete_bad_keys {
 sub validate  {
    my ($self, $params, @keys) = @_;

+    # If $params is defined but not a reference, then we weren't
+    # sent any parameters at all, and we're getting @keys where
+    # $params should be.
+    return ($self, undef) if (defined $params and !ref $params);
+    
    # If @keys is not empty then we convert any named 
    # parameters that have scalar values to arrayrefs
    # that match.