Bug 348282: importxml.pl throws Bugzilla::Bug::ValidateTime warnings if the time…

Bug 348282: importxml.pl throws Bugzilla::Bug::ValidateTime warnings if the time value is not defined and param timetrackinggroup defined - Patch by GuzmÃ¡n BrasÃ³ <gbn@hqso.net> r/a=LpSolit

Bug 348282: importxml.pl throws Bugzilla::Bug::ValidateTime warnings if the time…
121badd2 · lpsolit%gmail.com · ef1b5931 · 121badd2
Commit 121badd2 authored Feb 06, 2007 by lpsolit%gmail.com
Show whitespace changes
Inline Side-by-side

Showing with 10 additions and 0 deletions

importxml.pl importxml.pl +10 -0

No files found.
--- a/importxml.pl
+++ b/importxml.pl
@@ -791,6 +791,7 @@ sub process_bug {
          || undef;
        push( @values, $date );
        push( @query,  "deadline" );
+        if ( defined $bug_fields{'estimated_time'} ) {
            eval {
                Bugzilla::Bug::ValidateTime($bug_fields{'estimated_time'}, "e");
            };
@@ -798,6 +799,8 @@ sub process_bug {
                push( @values, $bug_fields{'estimated_time'} );
                push( @query,  "estimated_time" );
            }
+        }
+        if ( defined $bug_fields{'remaining_time'} ) {
            eval {
                Bugzilla::Bug::ValidateTime($bug_fields{'remaining_time'}, "r");
            };
@@ -805,6 +808,8 @@ sub process_bug {
                push( @values, $bug_fields{'remaining_time'} );
                push( @query,  "remaining_time" );
            }
+        }
+        if ( defined $bug_fields{'actual_time'} ) {
            eval {
                Bugzilla::Bug::ValidateTime($bug_fields{'actual_time'}, "a");
            };
@@ -813,6 +818,11 @@ sub process_bug {
                $err .= "Invalid Actual Time. Setting to 0.0\n";
            }
        }
+        else {
+            $bug_fields{'actual_time'} = 0.0;
+            $err .= "Actual time not defined. Setting to 0.0\n";
+        }
+    }

    # Reporter Assignee QA Contact
    my $exporterid = $exporter->id;