Bug 460074: Make post_bug.cgi use should_set for array fields, so they

are undef in Bugzilla::Bug->create if not passed to post_bug. This fixes a bug with the guided bug form creating bugs without any groups. r=LpSolit, a=mkanat

Bug 460074: Make post_bug.cgi use should_set for array fields, so they
3a8142ae · Max Kanat-Alexander · 1a34c347 · 3a8142ae · 3a8142ae
Commit 3a8142ae authored Aug 15, 2011 by Max Kanat-Alexander
Show whitespace changes
Inline Side-by-side

Showing with 6 additions and 2 deletions

post_bug.cgi post_bug.cgi +5 -2

create.html.tmpl template/en/default/bug/create/create.html.tmpl +1 -0

No files found.
--- a/post_bug.cgi
+++ b/post_bug.cgi
@@ -153,14 +153,17 @@ my %bug_params;
 foreach my $field (@bug_fields) {
    $bug_params{$field} = $cgi->param($field);
 }
-$bug_params{'cc'}          = [$cgi->param('cc')];
+foreach my $field (qw(cc groups)) {
-$bug_params{'groups'}      = [$cgi->param('groups')];
+    next if !$cgi->should_set($field);
+    $bug_params{$field} = [$cgi->param($field)];
+}
 $bug_params{'comment'} = $comment;
 my @multi_selects = grep {$_->type == FIELD_TYPE_MULTI_SELECT && $_->enter_bug}
                         Bugzilla->active_custom_fields;
 foreach my $field (@multi_selects) {
+    next if !$cgi->should_set($field->name);
    $bug_params{$field->name} = [$cgi->param($field->name)];
 }

--- a/template/en/default/bug/create/create.html.tmpl
+++ b/template/en/default/bug/create/create.html.tmpl
@@ -665,6 +665,7 @@ TUI_hide_default('attachment_text_field');
      <br>
      <!-- Checkboxes -->
+      <input type="hidden" name="defined_groups" value="1">
      [% FOREACH group = product.groups_available %]
        <input type="checkbox" id="group_[% group.id FILTER html %]"
               name="groups" value="[% group.name FILTER html %]"