Skip to content

bugzilla
bugzilla
Commit 503f732b authored by mkanat%bugzilla.org's avatar mkanat%bugzilla.org
Browse files
Options

Bug 474997: Make update_see_also actually return the right thing

Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=dkl, a=mkanat
parent c49af480
Show whitespace changes
Inline Side-by-side
Showing with 6 additions and 2 deletions
Bugzilla/WebService/Bug.pm
View file @ 503f732b
...@@ -375,14 +375,14 @@ sub update_see_also { ...@@ -375,14 +375,14 @@ sub update_see_also {
foreach my $bug (@bugs) { foreach my $bug (@bugs) {
my $change = $bug->update(); my $change = $bug->update();
if (my $see_also = $change->{see_also}) { if (my $see_also = $change->{see_also}) {
$changes{$bug->id} = { $changes{$bug->id}->{see_also} = {
removed => [split(', ', $see_also->[0])], removed => [split(', ', $see_also->[0])],
added => [split(', ', $see_also->[1])], added => [split(', ', $see_also->[1])],
}; };
} }
else { else {
# We still want a changes entry, for API consistency. # We still want a changes entry, for API consistency.
$changes{$bug->id} = { added => [], removed => [] }; $changes{$bug->id}->{see_also} = { added => [], removed => [] };
} }
Bugzilla::BugMail::Send($bug->id, { changer => $user->login }); Bugzilla::BugMail::Send($bug->id, { changer => $user->login });
...@@ -1372,15 +1372,19 @@ bug ids 1 and 2: ...@@ -1372,15 +1372,19 @@ bug ids 1 and 2:
{ {
changes => { changes => {
1 => { 1 => {
see_also => {
added => (an array of bug URLs), added => (an array of bug URLs),
removed => (an array of bug URLs), removed => (an array of bug URLs),
}
}, },
2 => { 2 => {
see_also => {
added => (an array of bug URLs), added => (an array of bug URLs),
removed => (an array of bug URLs), removed => (an array of bug URLs),
} }
} }
} }
}
This return value allows you to tell what this method actually did. It is in This return value allows you to tell what this method actually did. It is in
this format to be compatible with the return value of a future C<Bug.update> this format to be compatible with the return value of a future C<Bug.update>
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment