Commit 6010f040 authored by mkanat%bugzilla.org's avatar mkanat%bugzilla.org

Bug 346245: attribute parameter 'johndoe@company.tld' is not a hash ref at…

Bug 346245: attribute parameter 'johndoe@company.tld' is not a hash ref at Bugzilla/Auth/Verify.pm line 112 Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=wurblzap, a=myk
parent b07bd7dc
...@@ -102,7 +102,7 @@ sub create_or_update_user { ...@@ -102,7 +102,7 @@ sub create_or_update_user {
# Now that we have a valid User, we need to see if any data has to be # Now that we have a valid User, we need to see if any data has to be
# updated. # updated.
if ($username && $user->login ne $username) { if ($username && lc($user->login) ne lc($username)) {
validate_email_syntax($username) validate_email_syntax($username)
|| return { failure => AUTH_ERROR, error => 'auth_invalid_email', || return { failure => AUTH_ERROR, error => 'auth_invalid_email',
details => {addr => $username} }; details => {addr => $username} };
...@@ -110,7 +110,7 @@ sub create_or_update_user { ...@@ -110,7 +110,7 @@ sub create_or_update_user {
# placeholder, and we've already validated it, so it's safe. # placeholder, and we've already validated it, so it's safe.
trick_taint($username); trick_taint($username);
$dbh->do('UPDATE profiles SET login_name = ? WHERE userid = ?', $dbh->do('UPDATE profiles SET login_name = ? WHERE userid = ?',
$username, $user->id); undef, $username, $user->id);
} }
if ($real_name && $user->name ne $real_name) { if ($real_name && $user->name ne $real_name) {
# $real_name is more than likely tainted, but we only use it # $real_name is more than likely tainted, but we only use it
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment