Commit 7d01e4bc authored by timeless%mozdev.org's avatar timeless%mozdev.org

Bug 321691 duplicates.cgi doesn't use <th>

r=lpsolit a=justdave
parent c7a58f1e
...@@ -104,10 +104,6 @@ ...@@ -104,10 +104,6 @@
], ],
'reports/duplicates-table.html.tmpl' => [ 'reports/duplicates-table.html.tmpl' => [
'"&amp;maxrows=$maxrows" IF maxrows',
'"&amp;changedsince=$changedsince" IF changedsince',
'"&amp;bug_id=$bug_ids_string&amp;sortvisible=1"
IF sortvisible',
'column.name', 'column.name',
'column.description', 'column.description',
'bug.id', 'bug.id',
......
...@@ -48,6 +48,7 @@ ...@@ -48,6 +48,7 @@
[% IF bug_ids.size > 0 %] [% IF bug_ids.size > 0 %]
<table border> <table border>
<thead>
<tr bgcolor="#CCCCCC"> <tr bgcolor="#CCCCCC">
[% FOREACH column = [ { name => "id", description => "$terms.Bug #" }, [% FOREACH column = [ { name => "id", description => "$terms.Bug #" },
{ name => "count", description => "Dupe<br>Count" }, { name => "count", description => "Dupe<br>Count" },
...@@ -64,9 +65,7 @@ ...@@ -64,9 +65,7 @@
[%# Small hack to keep delta column out if we don't need it %] [%# Small hack to keep delta column out if we don't need it %]
[% NEXT IF column.name == "delta" AND NOT dobefore %] [% NEXT IF column.name == "delta" AND NOT dobefore %]
<td> <th>
<center>
<b>
[% bug_ids_string = bug_ids.join(',') %] [% bug_ids_string = bug_ids.join(',') %]
<a href="duplicates.cgi?sortby=[% column.name %] <a href="duplicates.cgi?sortby=[% column.name %]
[% IF sortby == column.name %] [% IF sortby == column.name %]
...@@ -75,19 +74,17 @@ ...@@ -75,19 +74,17 @@
[%-# Some columns start off reversed %] [%-# Some columns start off reversed %]
[% "&amp;reverse=1" IF column.name.match('delta|count') %] [% "&amp;reverse=1" IF column.name.match('delta|count') %]
[% END %] [% END %]
[% "&amp;maxrows=$maxrows" IF maxrows %] [% IF maxrows %]&amp;maxrows=[% maxrows FILTER html %][% END %]
[% "&amp;changedsince=$changedsince" IF changedsince %] [% IF changedsince %]&amp;changedsince=[% changedsince FILTER html %][% END %]
[% "&amp;openonly=1" IF openonly %] [% "&amp;openonly=1" IF openonly %]
[% FOREACH p = query_products %]&amp;product=[% p FILTER html %][% END %] [% FOREACH p = query_products %]&amp;product=[% p FILTER html %][% END %]
[% IF format %]&amp;format=[% format FILTER html %][% END %] [% IF format %]&amp;format=[% format FILTER html %][% END %]
[% "&amp;bug_id=$bug_ids_string&amp;sortvisible=1" [% IF sortvisible %]&amp;bug_id=[% bug_ids_string FILTER html %]&amp;sortvisible=1[% END %]">
IF sortvisible %]">
[% column.description %]</a> [% column.description %]</a>
</b> </th>
</center>
</td>
[% END %] [% END %]
</tr> </tr>
</thead>
[% IF NOT sortby %] [% IF NOT sortby %]
[% sortby = "count"; reverse = "1" %] [% sortby = "count"; reverse = "1" %]
...@@ -107,6 +104,7 @@ ...@@ -107,6 +104,7 @@
[% END %] [% END %]
[%# *** Buglist *** %] [%# *** Buglist *** %]
<tbody>
[%# We need to keep track of the bug IDs we are actually displaying, because [%# We need to keep track of the bug IDs we are actually displaying, because
# if the user decides to sort the visible list, we need to know what that # if the user decides to sort the visible list, we need to know what that
...@@ -142,7 +140,7 @@ ...@@ -142,7 +140,7 @@
<td>[% bug.short_desc FILTER html %]</td> <td>[% bug.short_desc FILTER html %]</td>
</tr> </tr>
[% END %] [% END %]
</tbody>
</table> </table>
[% ELSE %] [% ELSE %]
<h3>No duplicate [% terms.bugs %] found.</h3> <h3>No duplicate [% terms.bugs %] found.</h3>
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment