Commit 901d9285 authored by bugreport%peshkin.net's avatar bugreport%peshkin.net

Bug 172010 voting broken on tip

Regression from 43600 and 157756 2xr=bbaetz
parent baada6e8
......@@ -904,7 +904,7 @@ sub CheckIfVotedConfirmed {
SendSQL("SELECT bugs.votes, bugs.bug_status, products.votestoconfirm, " .
" bugs.everconfirmed " .
"FROM bugs, products " .
"WHERE bugs.bug_id = $id AND products.product_id = bugs.product_id");
"WHERE bugs.bug_id = $id AND products.id = bugs.product_id");
my ($votes, $status, $votestoconfirm, $everconfirmed) = (FetchSQLData());
if ($votes >= $votestoconfirm && $status eq $::unconfirmedstate) {
SendSQL("UPDATE bugs SET bug_status = 'NEW', everconfirmed = 1 " .
......
......@@ -134,6 +134,7 @@ sub show_user {
my $canedit = 1 if ($name eq $::COOKIE{'Bugzilla_login'});
SendSQL("LOCK TABLES bugs READ, products READ, votes WRITE,
cc READ, bug_group_map READ, user_group_map READ,
cc AS selectVisible_cc READ");
if ($canedit && $bug_id) {
......@@ -314,7 +315,8 @@ sub record_votes {
# for products that only allow one vote per bug). In that case, we still
# need to clear the user's votes from the database.
my %affected;
SendSQL("LOCK TABLES bugs write, votes write, products read");
SendSQL("LOCK TABLES bugs write, votes write, products read, cc read,
user_group_map read, bug_group_map read");
# Take note of, and delete the user's old votes from the database.
SendSQL("SELECT bug_id FROM votes WHERE who = $who");
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment