Bug 398707: whine.pl should use transactions for database interaction - Patch by…

Bug 398707: whine.pl should use transactions for database interaction - Patch by Emmanuel Seyman <eseyman@linagora.com> r/a=mkanat

Bug 398707: whine.pl should use transactions for database interaction - Patch by…
bd370f37 · lpsolit%gmail.com · 1aec31a1 · bd370f37
Commit bd370f37 authored Oct 08, 2007 by lpsolit%gmail.com
Show whitespace changes
Inline Side-by-side

Showing with 2 additions and 7 deletions

whine.pl whine.pl +2 -7

No files found.
--- a/whine.pl
+++ b/whine.pl
@@ -206,12 +206,7 @@ sub get_next_event {
    # Loop until there's something to return
    until (scalar keys %{$event}) {

-        $dbh->bz_lock_tables('whine_schedules WRITE',
-                             'whine_events READ',
-                             'profiles READ',
-                             'groups READ',
-                             'group_group_map READ',
-                             'user_group_map READ');
+        $dbh->bz_start_transaction();

        # Get the event ID for the first pending schedule
        $sth_next_scheduled_event->execute;
@@ -275,7 +270,7 @@ sub get_next_event {
            reset_timer($sid);
        }

-        $dbh->bz_unlock_tables();
+        $dbh->bz_commit_transaction();

        # Only set $event if the user is allowed to do whining
        if ($owner->in_group('bz_canusewhines')) {