Skip to content

bugzilla
bugzilla
Commit d9ba51c3 authored by Dylan William Hardison's avatar Dylan William Hardison
Browse files
Options

Bug 1309278 - Cache::Memcached::Fast returns tainted data if the key is tainted

r=dkl
parent d328d409
Show whitespace changes
Inline Side-by-side
Showing with 2 additions and 0 deletions
Bugzilla/Memcached.pm
View file @ d9ba51c3
...@@ -13,6 +13,7 @@ use warnings; ...@@ -13,6 +13,7 @@ use warnings;
use Bugzilla::Error; use Bugzilla::Error;
use Scalar::Util qw(blessed); use Scalar::Util qw(blessed);
use Bugzilla::Util qw(trick_taint);
use URI::Escape; use URI::Escape;
# memcached keys have a maximum length of 250 bytes # memcached keys have a maximum length of 250 bytes
...@@ -219,6 +220,7 @@ sub _config_prefix { ...@@ -219,6 +220,7 @@ sub _config_prefix {
sub _encode_key { sub _encode_key {
my ($self, $key) = @_; my ($self, $key) = @_;
$key = $self->_global_prefix . '.' . uri_escape_utf8($key); $key = $self->_global_prefix . '.' . uri_escape_utf8($key);
trick_taint($key) if defined $key;
return length($self->{namespace} . $key) > MAX_KEY_LENGTH return length($self->{namespace} . $key) > MAX_KEY_LENGTH
? undef ? undef
: $key; : $key;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment