Fix for bug 83872: Bugzilla no longer requires the Mysql Perl module, but the…

Fix for bug 83872: Bugzilla no longer requires the Mysql Perl module, but the DBD::mysql Perl module, and has been this way for a while. Fixing the version checks in checksetup.pl to check the correct module. Also eliminates a DBD::mysql-specific database function call that is depricated in the current version of DBD_mysql. Patch by Dave Miller <justdave@syndicomm.com> r= jake@acutex.net, tara@tequilarista.org
parent ce9c76eb
...@@ -190,8 +190,8 @@ sub have_vers { ...@@ -190,8 +190,8 @@ sub have_vers {
my @missing = (); my @missing = ();
unless (have_vers("DBI","1.13")) { push @missing,"DBI" } unless (have_vers("DBI","1.13")) { push @missing,"DBI" }
unless (have_vers("Data::Dumper",0)) { push @missing,"Data::Dumper" } unless (have_vers("Data::Dumper",0)) { push @missing,"Data::Dumper" }
unless (have_vers("Mysql",0)) { push @missing,"Mysql" } unless (have_vers("DBD::mysql","1.2209")) { push @missing,"DBD::mysql" }
unless (have_vers("Date::Parse",0)) { push @missing,"Data::Parse" } unless (have_vers("Date::Parse",0)) { push @missing,"Date::Parse" }
# If CGI::Carp was loaded successfully for version checking, it changes the # If CGI::Carp was loaded successfully for version checking, it changes the
# die and warn handlers, we don't want them changed, so we need to stash the # die and warn handlers, we don't want them changed, so we need to stash the
...@@ -942,10 +942,8 @@ $table{duplicates} = ...@@ -942,10 +942,8 @@ $table{duplicates} =
# Create tables # Create tables
########################################################################### ###########################################################################
# The current DBI::mysql tells me to use this: # Get a list of the existing tables (if any) in the database
#my @tables = map { $_ =~ s/.*\.//; $_ } $dbh->tables(); my @tables = map { $_ =~ s/.*\.//; $_ } $dbh->tables;
# but that doesn't work on a freshly created database, so I still use
my @tables = $dbh->func('_ListTables');
#print 'Tables: ', join " ", @tables, "\n"; #print 'Tables: ', join " ", @tables, "\n";
# add lines here if you add more --LOCAL-- config vars that end up in the enums: # add lines here if you add more --LOCAL-- config vars that end up in the enums:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment