Commit e330e0c5 authored by Matt Selsky's avatar Matt Selsky Committed by Tiago Mello

Bug 617802: Add see also support for Rietveld installations on appspot.com

r=timello, a=LpSolit
parent 15f7b4a8
...@@ -57,6 +57,7 @@ use constant SUB_CLASSES => qw( ...@@ -57,6 +57,7 @@ use constant SUB_CLASSES => qw(
Bugzilla::BugUrl::MantisBT Bugzilla::BugUrl::MantisBT
Bugzilla::BugUrl::SourceForge Bugzilla::BugUrl::SourceForge
Bugzilla::BugUrl::ReviewBoard Bugzilla::BugUrl::ReviewBoard
Bugzilla::BugUrl::Rietveld
); );
############################### ###############################
......
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
#
# This Source Code Form is "Incompatible With Secondary Licenses", as
# defined by the Mozilla Public License, v. 2.0.
package Bugzilla::BugUrl::Rietveld;
use strict;
use base qw(Bugzilla::BugUrl);
###############################
#### Methods ####
###############################
sub should_handle {
my ($class, $uri) = @_;
return ($uri->authority =~ /\.appspot\.com$/i
and $uri->path =~ m#^/\d+(?:/|/show)?$#) ? 1 : 0;
}
sub _check_value {
my ($class, $uri) = @_;
$uri = $class->SUPER::_check_value($uri);
# Rietveld URLs have three forms:
# http(s)://example.appspot.com/1234
# http(s)://example.appspot.com/1234/
# http(s)://example.appspot.com/1234/show
if ($uri->path =~ m#^/(\d+)(?:/|/show)$#) {
# This is the shortest standard URL form for Rietveld issues,
# and so we reduce all URLs to this.
$uri->path('/' . $1);
}
# Make sure there are no query parameters.
$uri->query(undef);
# And remove any # part if there is one.
$uri->fragment(undef);
return $uri;
}
1;
...@@ -255,6 +255,7 @@ ...@@ -255,6 +255,7 @@
<li>A b[% %]ug in a MantisBT installation.</li> <li>A b[% %]ug in a MantisBT installation.</li>
<li>A b[% %]ug on sourceforge.net.</li> <li>A b[% %]ug on sourceforge.net.</li>
<li>A Review Board review request.</li> <li>A Review Board review request.</li>
<li>An issue in a Rietveld installation.</li>
</ul> </ul>
[% ELSIF reason == 'id' %] [% ELSIF reason == 'id' %]
There is no valid [% terms.bug %] id in that URL. There is no valid [% terms.bug %] id in that URL.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment