Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
bugzilla
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
etersoft
bugzilla
Commits
e7663671
Commit
e7663671
authored
May 24, 2010
by
Max Kanat-Alexander
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
"part" can return "undef" for a list, so sometimes $has_deps or $no_deps
in Bugzilla::Object::_sort_by_deps were undef.
https://bugzilla.mozilla.org/show_bug.cgi?id=567303
parent
2d57ca91
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
2 additions
and
2 deletions
+2
-2
Object.pm
Bugzilla/Object.pm
+2
-2
No files found.
Bugzilla/Object.pm
View file @
e7663671
...
...
@@ -525,13 +525,13 @@ sub _sort_by_dep {
# For fields with no dependencies, we sort them alphabetically,
# so that validation always happens in a consistent order.
# Fields with no dependencies come at the start of the list.
my
@result
=
sort
@
$no_deps
;
my
@result
=
sort
@
{
$no_deps
||
[]
}
;
# Fields with dependencies all go at the end of the list, and if
# they have dependencies on *each other*, then they have to be
# sorted properly. We go through $has_deps in sorted order to be
# sure that fields always validate in a consistent order.
foreach
my
$field
(
sort
@
$has_deps
)
{
foreach
my
$field
(
sort
@
{
$has_deps
||
[]
}
)
{
if
(
!
grep
{
$_
eq
$field
}
@result
)
{
_insert_dep_field
(
$field
,
$has_deps
,
$dependencies
,
\
@result
);
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment