Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
bugzilla
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
etersoft
bugzilla
Commits
f770095a
Commit
f770095a
authored
Oct 21, 2010
by
Frédéric Buclin
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Bug 598014: Document how to mark the initial comment as private when using Bug.create()
r/a=mkanat
parent
c971c669
Show whitespace changes
Inline
Side-by-side
Showing
9 changed files
with
22 additions
and
16 deletions
+22
-16
Bug.pm
Bugzilla/Bug.pm
+2
-4
Bug.pm
Bugzilla/WebService/Bug.pm
+7
-0
enter_bug.cgi
enter_bug.cgi
+3
-3
post_bug.cgi
post_bug.cgi
+2
-2
process_bug.cgi
process_bug.cgi
+1
-1
create.html.tmpl
template/en/default/bug/create/create.html.tmpl
+3
-3
edit.html.tmpl
template/en/default/bug/edit.html.tmpl
+1
-1
midair.html.tmpl
template/en/default/bug/process/midair.html.tmpl
+2
-1
edit-multiple.html.tmpl
template/en/default/list/edit-multiple.html.tmpl
+1
-1
No files found.
Bugzilla/Bug.pm
View file @
f770095a
...
...
@@ -260,6 +260,7 @@ use constant FIELD_MAP => {
blocks
=>
'blocked'
,
is_confirmed
=>
'everconfirmed'
,
cc_accessible
=>
'cclist_accessible'
,
commentprivacy
=>
'comment_is_private'
,
creation_time
=>
'creation_ts'
,
creator
=>
'reporter'
,
description
=>
'comment'
,
...
...
@@ -1405,7 +1406,7 @@ sub _check_comment {
}
# Load up some data
my
$isprivate
=
$params
->
{
commentprivacy
};
my
$isprivate
=
delete
$params
->
{
comment_is_private
};
my
$timestamp
=
$params
->
{
creation_ts
};
# Create the new comment so we can check it
...
...
@@ -1420,9 +1421,6 @@ sub _check_comment {
$comment
->
{
isprivate
}
=
$isprivate
;
}
# Don't need this anymore as it is now in the comment hash
delete
$params
->
{
commentprivacy
};
# Validate comment. We have to do this special as a comment normally
# requires a bug to be already created. For a new bug, the first comment
# obviously can't get the bug if the bug is created after this
...
...
Bugzilla/WebService/Bug.pm
View file @
f770095a
...
...
@@ -2244,6 +2244,9 @@ don't want it to be assigned to the component owner.
=item C<cc> (array) - An array of usernames to CC on this bug.
=item C<comment_is_private> (boolean) - If set to true, the description
is private, otherwise it is assumed to be public.
=item C<groups> (array) - An array of group names to put this
bug into. You can see valid group names on the Permissions
tab of the Preferences screen, or, if you are an administrator,
...
...
@@ -2322,6 +2325,10 @@ B<Required>, due to a bug in Bugzilla.
Bugzilla 4.0, bugs were only added into Mandatory groups by this
method.
=item The C<comment_is_private> argument was added in Bugzilla B<4.0>.
Before Bugzilla 4.0, you had to use the undocumented C<commentprivacy>
argument.
=back
=back
...
...
enter_bug.cgi
View file @
f770095a
...
...
@@ -453,13 +453,13 @@ if ($cloned_bug_id) {
my
$isprivate
=
$bug_desc
->
is_private
;
$vars
->
{
'comment'
}
=
""
;
$vars
->
{
'comment
privacy
'
}
=
0
;
$vars
->
{
'comment
_is_private
'
}
=
0
;
if
(
!
$isprivate
||
Bugzilla
->
user
->
is_insider
)
{
# We use "body" to avoid any format_comment text, which would be
# pointless to clone.
$vars
->
{
'comment'
}
=
$bug_desc
->
body
;
$vars
->
{
'comment
privacy
'
}
=
$isprivate
;
$vars
->
{
'comment
_is_private
'
}
=
$isprivate
;
}
}
# end of cloned bug entry form
...
...
@@ -484,7 +484,7 @@ else {
$vars
->
{
'cc'
}
=
join
(
', '
,
$cgi
->
param
(
'cc'
));
$vars
->
{
'comment'
}
=
formvalue
(
'comment'
);
$vars
->
{
'comment
privacy'
}
=
formvalue
(
'commentprivacy
'
);
$vars
->
{
'comment
_is_private'
}
=
formvalue
(
'comment_is_private
'
);
}
# end of normal/bookmarked entry form
...
...
post_bug.cgi
View file @
f770095a
...
...
@@ -129,7 +129,7 @@ push(@bug_fields, qw(
alias
blocked
comment
privacy
comment
_is_private
bug_file_loc
bug_severity
bug_status
...
...
@@ -184,7 +184,7 @@ if (defined $cgi->param('version')) {
# Add an attachment if requested.
if
(
defined
(
$cgi
->
upload
(
'data'
))
||
$cgi
->
param
(
'attach_text'
))
{
$cgi
->
param
(
'isprivate'
,
$cgi
->
param
(
'comment
privacy
'
));
$cgi
->
param
(
'isprivate'
,
$cgi
->
param
(
'comment
_is_private
'
));
# Must be called before create() as it may alter $cgi->param('ispatch').
my
$content_type
=
Bugzilla::Attachment::
get_content_type
();
...
...
process_bug.cgi
View file @
f770095a
...
...
@@ -265,7 +265,7 @@ if (should_set('keywords')) {
if
(
should_set
(
'comment'
))
{
$set_all_fields
{
comment
}
=
{
body
=>
scalar
$cgi
->
param
(
'comment'
),
is_private
=>
scalar
$cgi
->
param
(
'comment
privacy
'
),
is_private
=>
scalar
$cgi
->
param
(
'comment
_is_private
'
),
};
}
if
(
should_set
(
'see_also'
))
{
...
...
template/en/default/bug/create/create.html.tmpl
View file @
f770095a
...
...
@@ -588,9 +588,9 @@ TUI_hide_default('attachment_text_field');
<th> </th>
<td colspan="3">
<input type="checkbox" id="comment
privacy" name="commentprivacy
"
[%
" checked=\"checked\"" IF commentprivacy
%]>
<label for="comment
privacy
">
<input type="checkbox" id="comment
_is_private" name="comment_is_private
"
[%
' checked="checked"' IF comment_is_private
%]>
<label for="comment
_is_private
">
Make description private (visible only to members of the
<strong>[% Param('insidergroup') FILTER html %]</strong> group)
</label>
...
...
template/en/default/bug/edit.html.tmpl
View file @
f770095a
...
...
@@ -1066,7 +1066,7 @@
<u>C</u>omments</b></label>:
[% IF user.is_insider %]
<input type="checkbox" name="comment
privacy
" value="1"
<input type="checkbox" name="comment
_is_private
" value="1"
id="newcommentprivacy"
onClick="updateCommentTagControl(this, form)">
<label for="newcommentprivacy">
...
...
template/en/default/bug/process/midair.html.tmpl
View file @
f770095a
...
...
@@ -94,7 +94,8 @@ You have the following choices:
<input type="hidden" name="id" value="[% cgi.param("id") FILTER html %]">
<input type="hidden" name="delta_ts" value="[% bug.delta_ts FILTER html %]">
<input type="hidden" name="comment" value="[% cgi.param("comment") FILTER html %]">
<input type="hidden" name="commentprivacy" value="[% cgi.param("commentprivacy") FILTER html %]">
<input type="hidden" name="comment_is_private"
value="[% cgi.param("comment_is_private") FILTER html %]">
<input type="hidden" name="longdesclength" value="[% bug.comments.size %]">
<input type="hidden" name="token" value="[% cgi.param("token") FILTER html %]">
<input type="submit" id="process_comment" value="Submit only my new comment">
...
...
template/en/default/list/edit-multiple.html.tmpl
View file @
f770095a
...
...
@@ -297,7 +297,7 @@
<b><label for="comment">Additional Comments:</label></b>
[% IF user.is_insider %]
<input type="checkbox" name="comment
privacy
" value="1"
<input type="checkbox" name="comment
_is_private
" value="1"
id="newcommentprivacy"
onClick="updateCommentTagControl(this, form)"/>
<label for="newcommentprivacy">
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment