input/curl: disable `CURLOPT_FAILONERROR`

Let OnHeaders() check the status. The status checking code was added by commit 4f021cbc in 2011, but in 2008, commit a8e81326 enabled `CURLOPT_FAILONERROR`, which means the status checking code never had any effect. This allows `LoadExcludeListOrLog()` to hide boring "404 Not Found" log messages via `IsFileNotFound()`.

input/curl: disable `CURLOPT_FAILONERROR`
5cd86e27 · Max Kellermann · 740cbe9e · 5cd86e27 · 5cd86e27
Commit 5cd86e27 authored May 22, 2023 by Max Kellermann
Show whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

NEWS NEWS +1 -0

CurlInputPlugin.cxx src/input/plugins/CurlInputPlugin.cxx +0 -1

No files found.
--- a/NEWS
+++ b/NEWS
 ver 0.23.13 (not yet released)
 * input
  - curl: fix busy loop after connection failed
+  - curl: hide "404" log messages for non-existent ".mpdignore" files
 * archive
  - zzip: fix crash bug
 * database

--- a/src/input/plugins/CurlInputPlugin.cxx
+++ b/src/input/plugins/CurlInputPlugin.cxx
@@ -417,7 +417,6 @@ CurlInputStream::InitEasy()
 	request->SetOption(CURLOPT_HTTP200ALIASES, http_200_aliases);
 	request->SetOption(CURLOPT_FOLLOWLOCATION, 1L);
 	request->SetOption(CURLOPT_MAXREDIRS, 5L);
-	request->SetOption(CURLOPT_FAILONERROR, 1L);
 	/* this option eliminates the probe request when
 	   username/password are specified */