db/proxy: throw DatabaseError on error

65386f52 · Max Kellermann · 5b8dce74 · 65386f52
Commit 65386f52 authored Feb 28, 2016 by Max Kellermann
Show whitespace changes
Inline Side-by-side

Showing with 3 additions and 5 deletions

ProxyDatabasePlugin.cxx src/db/plugins/ProxyDatabasePlugin.cxx +3 -5

No files found.
--- a/src/db/plugins/ProxyDatabasePlugin.cxx
+++ b/src/db/plugins/ProxyDatabasePlugin.cxx
@@ -517,11 +517,9 @@ ProxyDatabase::GetSong(const char *uri, Error &error) const
 		return nullptr;
 	}
-	if (song == nullptr) {
+	if (song == nullptr)
-		error.Format(db_domain, (int)DatabaseErrorCode::NOT_FOUND,
+		throw DatabaseError(DatabaseErrorCode::NOT_FOUND,
-			     "No such song: %s", uri);
+				    "No such song");
-		return nullptr;
-	}
 	return new AllocatedProxySong(song);
 }