Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
M
mpd
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Иван Мажукин
mpd
Commits
9ef1cf15
Commit
9ef1cf15
authored
May 30, 2021
by
Rosen Penev
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
clang-tidy: default virtual destructors
Found with cppcoreguidelines-special-member-functions Signed-off-by:
Rosen Penev
<
rosenp@gmail.com
>
parent
679b3bc0
Show whitespace changes
Inline
Side-by-side
Showing
9 changed files
with
11 additions
and
11 deletions
+11
-11
EncoderInterface.hxx
src/encoder/EncoderInterface.hxx
+2
-2
Filter.hxx
src/filter/Filter.hxx
+1
-1
Prepared.hxx
src/filter/Prepared.hxx
+1
-1
MixerInternal.hxx
src/mixer/MixerInternal.hxx
+1
-1
Explorer.hxx
src/neighbor/Explorer.hxx
+1
-1
Resampler.hxx
src/pcm/Resampler.hxx
+1
-1
SongEnumerator.hxx
src/playlist/SongEnumerator.hxx
+1
-1
ISongFilter.hxx
src/song/ISongFilter.hxx
+1
-1
StorageInterface.hxx
src/storage/StorageInterface.hxx
+2
-2
No files found.
src/encoder/EncoderInterface.hxx
View file @
9ef1cf15
...
...
@@ -35,7 +35,7 @@ class Encoder {
public
:
explicit
Encoder
(
bool
_implements_tag
)
noexcept
:
implements_tag
(
_implements_tag
)
{}
virtual
~
Encoder
()
noexcept
{}
virtual
~
Encoder
()
noexcept
=
default
;
bool
ImplementsTag
()
const
noexcept
{
return
implements_tag
;
...
...
@@ -111,7 +111,7 @@ public:
class
PreparedEncoder
{
public
:
virtual
~
PreparedEncoder
()
noexcept
{}
virtual
~
PreparedEncoder
()
noexcept
=
default
;
/**
* Opens the object. You must call this prior to using it.
...
...
src/filter/Filter.hxx
View file @
9ef1cf15
...
...
@@ -36,7 +36,7 @@ protected:
}
public
:
virtual
~
Filter
()
noexcept
{}
virtual
~
Filter
()
noexcept
=
default
;
/**
* Returns the #AudioFormat produced by FilterPCM().
...
...
src/filter/Prepared.hxx
View file @
9ef1cf15
...
...
@@ -27,7 +27,7 @@ class Filter;
class
PreparedFilter
{
public
:
virtual
~
PreparedFilter
()
{}
virtual
~
PreparedFilter
()
=
default
;
/**
* Opens the filter, preparing it for FilterPCM().
...
...
src/mixer/MixerInternal.hxx
View file @
9ef1cf15
...
...
@@ -57,7 +57,7 @@ public:
Mixer
(
const
Mixer
&
)
=
delete
;
virtual
~
Mixer
()
{}
virtual
~
Mixer
()
=
default
;
bool
IsPlugin
(
const
MixerPlugin
&
other
)
const
noexcept
{
return
&
plugin
==
&
other
;
...
...
src/neighbor/Explorer.hxx
View file @
9ef1cf15
...
...
@@ -49,7 +49,7 @@ public:
/**
* Free instance data.
*/
virtual
~
NeighborExplorer
()
noexcept
{}
virtual
~
NeighborExplorer
()
noexcept
=
default
;
/**
* Start exploring the neighborhood.
...
...
src/pcm/Resampler.hxx
View file @
9ef1cf15
...
...
@@ -31,7 +31,7 @@ struct AudioFormat;
*/
class
PcmResampler
{
public
:
virtual
~
PcmResampler
()
{}
virtual
~
PcmResampler
()
=
default
;
/**
* Opens the resampler, preparing it for Resample().
...
...
src/playlist/SongEnumerator.hxx
View file @
9ef1cf15
...
...
@@ -30,7 +30,7 @@ class DetachedSong;
*/
class
SongEnumerator
{
public
:
virtual
~
SongEnumerator
()
noexcept
{}
virtual
~
SongEnumerator
()
noexcept
=
default
;
/**
* Obtain the next song. Returns nullptr if there are no more
...
...
src/song/ISongFilter.hxx
View file @
9ef1cf15
...
...
@@ -31,7 +31,7 @@ using ISongFilterPtr = std::unique_ptr<ISongFilter>;
class
ISongFilter
{
public
:
virtual
~
ISongFilter
()
noexcept
{}
virtual
~
ISongFilter
()
noexcept
=
default
;
virtual
ISongFilterPtr
Clone
()
const
noexcept
=
0
;
...
...
src/storage/StorageInterface.hxx
View file @
9ef1cf15
...
...
@@ -33,7 +33,7 @@ class StorageDirectoryReader {
public
:
StorageDirectoryReader
()
=
default
;
StorageDirectoryReader
(
const
StorageDirectoryReader
&
)
=
delete
;
virtual
~
StorageDirectoryReader
()
noexcept
{}
virtual
~
StorageDirectoryReader
()
noexcept
=
default
;
virtual
const
char
*
Read
()
noexcept
=
0
;
...
...
@@ -47,7 +47,7 @@ class Storage {
public
:
Storage
()
=
default
;
Storage
(
const
Storage
&
)
=
delete
;
virtual
~
Storage
()
noexcept
{}
virtual
~
Storage
()
noexcept
=
default
;
/**
* Throws #std::runtime_error on error.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment