Skip to content

M
mpd
Commit a1882f48 authored by Max Kellermann's avatar Max Kellermann
Browse files
Options

decoder/vorbis: handle uri==NULL

This fixes a theoretical crash, which has never occurred in practice.
parent c3569814
Show whitespace changes
Inline Side-by-side
Showing with 4 additions and 0 deletions
NEWS
View file @ a1882f48
...@@ -4,6 +4,7 @@ ver 0.15.11 (2010/??/??) ...@@ -4,6 +4,7 @@ ver 0.15.11 (2010/??/??)
* decoders: * decoders:
- mp4ff: support tags "album artist", "albumartist", "band" - mp4ff: support tags "album artist", "albumartist", "band"
- mikmod: fix memory leak - mikmod: fix memory leak
- vorbis: handle uri==NULL
- ffmpeg: free AVFormatContext on error - ffmpeg: free AVFormatContext on error
- ffmpeg: read more metadata - ffmpeg: read more metadata
* playlist: emit IDLE_OPTIONS when resetting single mode * playlist: emit IDLE_OPTIONS when resetting single mode
......
src/decoder/vorbis_plugin.c
View file @ a1882f48
...@@ -233,6 +233,9 @@ oggvorbis_seekable(struct decoder *decoder) ...@@ -233,6 +233,9 @@ oggvorbis_seekable(struct decoder *decoder)
bool seekable; bool seekable;
uri = decoder_get_uri(decoder); uri = decoder_get_uri(decoder);
if (uri == NULL)
return false;
/* disable seeking on remote streams, because libvorbis seeks /* disable seeking on remote streams, because libvorbis seeks
around like crazy, and due to being very expensive, this around like crazy, and due to being very expensive, this
delays song playback my 10 or 20 seconds */ delays song playback my 10 or 20 seconds */
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment