Commit a2b77c88 authored by Max Kellermann's avatar Max Kellermann

decoder/ffmpeg, test/test_protocol: catch exceptions by reference

Work around -Werror=catch-value.
parent 18add294
...@@ -2,6 +2,7 @@ ver 0.20.12 (not yet released) ...@@ -2,6 +2,7 @@ ver 0.20.12 (not yet released)
* input * input
- curl: fix seeking - curl: fix seeking
* decoder * decoder
- ffmpeg: fix GCC 8 warning
- vorbis: fix Tremor support - vorbis: fix Tremor support
* player * player
- log message when decoder is too slow - log message when decoder is too slow
......
...@@ -258,7 +258,7 @@ FfmpegSendFrame(DecoderClient &client, InputStream &is, ...@@ -258,7 +258,7 @@ FfmpegSendFrame(DecoderClient &client, InputStream &is,
try { try {
output_buffer = copy_interleave_frame(codec_context, frame, output_buffer = copy_interleave_frame(codec_context, frame,
buffer); buffer);
} catch (const std::exception e) { } catch (const std::exception &e) {
/* this must be a serious error, e.g. OOM */ /* this must be a serious error, e.g. OOM */
LogError(e); LogError(e);
return DecoderCommand::STOP; return DecoderCommand::STOP;
......
...@@ -37,7 +37,7 @@ ArgParserTest::TestRange() ...@@ -37,7 +37,7 @@ ArgParserTest::TestRange()
try { try {
range = ParseCommandArgRange("-2"); range = ParseCommandArgRange("-2");
CPPUNIT_ASSERT(false); CPPUNIT_ASSERT(false);
} catch (ProtocolError) { } catch (const ProtocolError &) {
CPPUNIT_ASSERT(true); CPPUNIT_ASSERT(true);
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment