no busy-waiting for the player process

The function player_command() inherited the busy-waiting algorithm from the old code; throw in a wait_main_task() to do idle waiting.

no busy-waiting for the player process
cdaa26c8 · Max Kellermann · b1de50f9 · cdaa26c8
Commit cdaa26c8 authored Aug 26, 2008 by Max Kellermann
Show whitespace changes
Inline Side-by-side

Showing with 3 additions and 2 deletions

player.c src/player.c +3 -2

No files found.
--- a/src/player.c
+++ b/src/player.c
@@ -97,9 +97,10 @@ static void set_current_song(Song *song)
 static void player_command(enum player_command cmd)
 {
 	pc.command = cmd;
-	while (pc.command != PLAYER_COMMAND_NONE)
-		/* FIXME: _nb() variant is probably wrong here, and everywhere... */
+	while (pc.command != PLAYER_COMMAND_NONE) {
 		notify_signal(&pc.notify);
+		wait_main_task();
+	}
 }

 void player_command_finished()