Skip to content

M
mpd
Commit d38034bb authored by Max Kellermann's avatar Max Kellermann
Browse files
Options

fs/io/FileOutputStream: don't auto-delete file on WIN32

The file handle is never reset to INVALID_HANDLE_VALUE, and thus the destructor will assume the operation shall be cancelled and will delete the temporary file. This was a major breakage for saving the database file and the state file.
parent b3fe3e8b
Show whitespace changes
Inline Side-by-side
Showing with 3 additions and 0 deletions
NEWS
View file @ d38034bb
...@@ -6,6 +6,7 @@ ver 0.19.9 (not yet released) ...@@ -6,6 +6,7 @@ ver 0.19.9 (not yet released)
* fix build failure with uClibc * fix build failure with uClibc
* fix build failure on non-POSIX operating systems * fix build failure on non-POSIX operating systems
* fix dependency issue on parallel Android build * fix dependency issue on parallel Android build
* fix database/state file saving on Windows
ver 0.19.8 (2015/01/14) ver 0.19.8 (2015/01/14)
* input * input
......
src/fs/io/FileOutputStream.cxx
View file @ d38034bb
...@@ -62,6 +62,7 @@ FileOutputStream::Commit(gcc_unused Error &error) ...@@ -62,6 +62,7 @@ FileOutputStream::Commit(gcc_unused Error &error)
assert(IsDefined()); assert(IsDefined());
CloseHandle(handle); CloseHandle(handle);
handle = INVALID_HANDLE_VALUE;
return true; return true;
} }
...@@ -71,6 +72,7 @@ FileOutputStream::Cancel() ...@@ -71,6 +72,7 @@ FileOutputStream::Cancel()
assert(IsDefined()); assert(IsDefined());
CloseHandle(handle); CloseHandle(handle);
handle = INVALID_HANDLE_VALUE;
RemoveFile(path); RemoveFile(path);
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment