filter/ReplayGain: invoke the MixerListener after volume change

This ensures that Partition::OnMixerVolumeChanged() invokes MixerMemento::InvalidateHardwareVolume(), clearing the cached volume level. Closes https://github.com/MusicPlayerDaemon/MPD/issues/1526

filter/ReplayGain: invoke the MixerListener after volume change
e2d4654e · Max Kellermann · 2b8f1170 · e2d4654e · e2d4654e
Commit e2d4654e authored Aug 18, 2022 by Max Kellermann
Show whitespace changes
Inline Side-by-side

Showing with 9 additions and 3 deletions

NEWS NEWS +2 -0

ReplayGainFilterPlugin.cxx src/filter/plugins/ReplayGainFilterPlugin.cxx +7 -3

No files found.
--- a/NEWS
+++ b/NEWS
@@ -3,6 +3,8 @@ ver 0.23.9 (not yet released)
  - cdio_paranoia: add options "mode" and "skip"
 * decoder
  - ffmpeg: support FFmpeg 5.1
+* filter
+  - replay gain: fix delayed volume display with handler=mixer
 * output
  - pipewire: set app icon
 * fix bogus volume levels with multiple partitions

--- a/src/filter/plugins/ReplayGainFilterPlugin.cxx
+++ b/src/filter/plugins/ReplayGainFilterPlugin.cxx
@@ -23,6 +23,8 @@
 #include "ReplayGainInfo.hxx"
 #include "ReplayGainConfig.hxx"
 #include "mixer/MixerControl.hxx"
+#include "mixer/MixerInternal.hxx"
+#include "mixer/Listener.hxx"
 #include "pcm/AudioFormat.hxx"
 #include "pcm/Volume.hxx"
 #include "util/ConstBuffer.hxx"
@@ -171,9 +173,11 @@ ReplayGainFilter::Update()
 		try {
 			mixer_set_volume(mixer, _volume);
-			/* TODO: emit this idle event only for the
+			/* invoke the mixer's listener manually, just
-			   current partition */
+			   in case the mixer implementation didn't do
-			idle_add(IDLE_MIXER);
+			   that already (this depends on the
+			   implementation) */
+			mixer->listener.OnMixerVolumeChanged(*mixer, _volume);
 		} catch (...) {
 			LogError(std::current_exception(),
 				 "Failed to update hardware mixer");