player/Thread: wake up the decoder when the pipe has run empty

This is another instance of the kludge we already have a few lines above that. It works around a deadlock/race condition revealed by commit 98a7c62d

player/Thread: wake up the decoder when the pipe has run empty
efb528f9 · Max Kellermann · edcd0b99 · efb528f9
Commit efb528f9 authored Jan 12, 2018 by Max Kellermann
Show whitespace changes
Inline Side-by-side

Showing with 8 additions and 0 deletions

Thread.cxx src/player/Thread.cxx +8 -0

No files found.
--- a/src/player/Thread.cxx
+++ b/src/player/Thread.cxx
@@ -1027,7 +1027,9 @@ Player::Run() noexcept
 			/* wake up the decoder (just in case it's
 			   waiting for space in the MusicBuffer) and
 			   wait for it */
+			// TODO: eliminate this kludge
 			dc.Signal();
+
 			dc.WaitForDecoder();
 		} else if (IsDecoderAtNextSong()) {
 			/* at the beginning of a new song */
@@ -1049,6 +1051,12 @@ Player::Run() noexcept
 			   new PCM data in time: wait for the
 			   decoder */

+			/* wake up the decoder (just in case it's
+			   waiting for space in the MusicBuffer) and
+			   wait for it */
+			// TODO: eliminate this kludge
+			dc.Signal();
+
 			dc.WaitForDecoder();
 		}
 	}