0.10.0

ChangeLog

@@ -17,6 +17,8 @@ ver 0.10.0 (2004/3/3)
 16) Fix a bug, where one process may segfault, and cause more processes to spawn w/o killing ones that lost their parent.
 17) Fix a bug when the OSS device was unable to fetch the current volume,
 it would close the device (when it maybe previously closed by the exact same code)
+18) command.c cleanup by mackstann
+19) directory.c and command.c cleanup by tw-nym
 
 ver 0.9.4 (2004/1/21)
 1) Fix a bug where updated tag info wasn't being detected

doc/mpd.1

@@ -221,7 +221,7 @@ log_level               "default"
 .br
 bind_to_address         "any"
 .br
-#passwd                 "passwd@read,add,control,admin"
+#password               "password@read,add,control,admin"
 .br
 #default_permissions    "read,add,control,admin"
 .br

doc/mpdconf.example

@@ -32,6 +32,6 @@ save_absolute_paths_in_playlists "no"
 log_level		"default"
 # when bind_to_address is set to "any", MPD binds all available addresses
 bind_to_address 	"any"
-#passwd 		"passwd@read,add,control,admin"
+#password 		"password@read,add,control,admin"
 #default_permissions	"read,add,control,admin"
 #filesystem_charset	"UTF-8"

src/conf.c

@@ -168,7 +168,7 @@ char ** readConf(char * file) {
 		numberOfArgs = buffer2array(string,&array);
 		if(numberOfArgs==0) continue;
 		if(2!=numberOfArgs) {
-			ERROR("need two args in conf at: %s\n",string);
+			ERROR("improperly formated config line: %s\n",string);
 			exit(-1);
 		}
 		i = 0;

src/decode.c

@@ -199,8 +199,9 @@ void decodeSeek(PlayerControl * pc, AudioFormat * af, DecoderControl * dc,
 
 int decoderInit(PlayerControl * pc, Buffer * cb, AudioFormat *af, 
 			DecoderControl * dc) {
+	int pid;
 	decode_pid = &(pc->decode_pid);
-	int pid = fork();
+	pid = fork();
 
 	if(pid==0) {
 		/* CHILD */

src/permission.c

@@ -69,7 +69,6 @@ unsigned int parsePermissions(char * string) {
 }
 
 void initPermissions() {
-	permission_passwords = makeList(free);
 	char * passwordSets;
 	char * nextSet;
 	char * temp;
@@ -78,6 +77,8 @@ void initPermissions() {
 	char * password;
 	unsigned int * permission;
 
+	permission_passwords = makeList(free);
+
 	permission_default = PERMISSION_READ | PERMISSION_ADD | 
 				PERMISSION_CONTROL | PERMISSION_ADMIN;
 

src/player.c

@@ -402,17 +402,19 @@ float getPlayerCrossFade() {
 }
 
 void setPlayerCrossFade(float crossFadeInSeconds) {
+	PlayerControl * pc;
 	if(crossFadeInSeconds<0) crossFadeInSeconds = 0;
 
-	PlayerControl * pc = &(getPlayerData()->playerControl);
+	pc = &(getPlayerData()->playerControl);
 
 	pc->crossFade = crossFadeInSeconds;
 }
 
 void setPlayerSoftwareVolume(int volume) {
+	PlayerControl * pc;
 	volume = (volume>100) ? 100 : (volume<0 ? 0 : volume);
 
-	PlayerControl * pc = &(getPlayerData()->playerControl);
+	pc = &(getPlayerData()->playerControl);
 
 	pc->softwareVolume = volume;
 }