msi: Fix process token leak.

007833f1 · Christoph von Wittich · Alexandre Julliard · 0acfe688 · 007833f1
Commit 007833f1 authored Jan 20, 2008 by Christoph von Wittich Committed by Alexandre Julliard Jan 21, 2008
Show whitespace changes
Inline Side-by-side

Showing with 7 additions and 3 deletions

registry.c dlls/msi/registry.c +7 -3

No files found.
--- a/dlls/msi/registry.c
+++ b/dlls/msi/registry.c
@@ -478,13 +478,17 @@ static UINT get_user_sid(LPWSTR *usersid)
        return ERROR_FUNCTION_FAILED;

    size = sizeof(buf);
-    if (!GetTokenInformation(token, TokenUser, (void *)buf, size, &size))
+    if (!GetTokenInformation(token, TokenUser, (void *)buf, size, &size)) {
+        CloseHandle(token);
        return ERROR_FUNCTION_FAILED;
+    }

    user = (PTOKEN_USER)buf;
-    if (!ConvertSidToStringSidW(user->User.Sid, usersid))
+    if (!ConvertSidToStringSidW(user->User.Sid, usersid)) {
+        CloseHandle(token);
        return ERROR_FUNCTION_FAILED;
-
+    }
+    CloseHandle(token);
    return ERROR_SUCCESS;
 }