Commit 02efd4bb authored by Evan Stade's avatar Evan Stade Committed by Alexandre Julliard

gdiplus: Fix erroneous pen error checking.

parent 6baacf61
...@@ -33,8 +33,11 @@ GpStatus WINGDIPAPI GdipCreatePen1(ARGB color, FLOAT width, GpUnit unit, ...@@ -33,8 +33,11 @@ GpStatus WINGDIPAPI GdipCreatePen1(ARGB color, FLOAT width, GpUnit unit,
LOGBRUSH lb; LOGBRUSH lb;
GpPen *gp_pen; GpPen *gp_pen;
if(!pen)
return InvalidParameter;
gp_pen = GdipAlloc(sizeof(GpPen)); gp_pen = GdipAlloc(sizeof(GpPen));
if(!pen) return OutOfMemory; if(!gp_pen) return OutOfMemory;
gp_pen->style = GP_DEFAULT_PENSTYLE; gp_pen->style = GP_DEFAULT_PENSTYLE;
gp_pen->color = ARGB2COLORREF(color); gp_pen->color = ARGB2COLORREF(color);
...@@ -51,12 +54,10 @@ GpStatus WINGDIPAPI GdipCreatePen1(ARGB color, FLOAT width, GpUnit unit, ...@@ -51,12 +54,10 @@ GpStatus WINGDIPAPI GdipCreatePen1(ARGB color, FLOAT width, GpUnit unit,
0, NULL); 0, NULL);
} else { } else {
FIXME("UnitWorld, UnitPixel only supported units\n"); FIXME("UnitWorld, UnitPixel only supported units\n");
GdipFree(gp_pen);
return NotImplemented; return NotImplemented;
} }
if(!gp_pen)
return GenericError;
*pen = gp_pen; *pen = gp_pen;
return Ok; return Ok;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment