server: Set error to STATUS_UNSUCCESSFUL when the server fails to queue APC for a thread.

I've left another case of returning STATUS_PROCESS_IS_TERMINATING since that's not covered by the tests. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50704Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

server: Set error to STATUS_UNSUCCESSFUL when the server fails to queue APC for a thread.
050dc49b · Dmitry Timoshkov · Alexandre Julliard · 816b588e · 050dc49b · 050dc49b
Commit 050dc49b authored Mar 03, 2021 by Dmitry Timoshkov Committed by Alexandre Julliard Mar 03, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 3 deletions

sync.c dlls/kernel32/tests/sync.c +0 -2

thread.c server/thread.c +1 -1

No files found.
--- a/dlls/kernel32/tests/sync.c
+++ b/dlls/kernel32/tests/sync.c
@@ -2737,13 +2737,11 @@ static void test_QueueUserAPC(void)
    ok(ret == WAIT_OBJECT_0, "got %u\n", ret);

    ret = pNtQueueApcThread(thread, call_user_apc, (ULONG_PTR)user_apc, 0, 0);
-todo_wine
    ok(ret == STATUS_UNSUCCESSFUL, "got %#x\n", ret);

    SetLastError(0xdeadbeef);
    ret = QueueUserAPC(user_apc, thread, 0);
    ok(!ret, "QueueUserAPC should fail\n");
-todo_wine
    ok(GetLastError() == ERROR_GEN_FAILURE, "got %u\n", GetLastError());

    CloseHandle(thread);

--- a/server/thread.c
+++ b/server/thread.c
@@ -1763,7 +1763,7 @@ DECL_HANDLER(queue_apc)

    if (thread)
    {
-        if (!queue_apc( NULL, thread, apc )) set_error( STATUS_THREAD_IS_TERMINATING );
+        if (!queue_apc( NULL, thread, apc )) set_error( STATUS_UNSUCCESSFUL );
        release_object( thread );
    }
    else if (process)