server: Return error when hardware message is too large.

So that the client allocates a larger receive buffer when needed and not trigger the assert below when setting the reply message data. Signed-off-by: Rémi Bernon <rbernon@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

server: Return error when hardware message is too large.
095204a9 · Rémi Bernon · Alexandre Julliard · d416f1c4 · 095204a9
Commit 095204a9 authored Jan 12, 2022 by Rémi Bernon Committed by Alexandre Julliard Jan 12, 2022
Hide whitespace changes
Inline Side-by-side

Showing with 8 additions and 0 deletions

queue.c server/queue.c +8 -0

No files found.
--- a/server/queue.c
+++ b/server/queue.c
@@ -2145,6 +2145,14 @@ static int get_hardware_message( struct thread *thread, unsigned int hw_id, user
            clear_bits &= ~get_hardware_msg_bit( msg );
            continue;
        }
+
+        reply->total = msg->data_size;
+        if (msg->data_size > get_reply_max_size())
+        {
+            set_error( STATUS_BUFFER_OVERFLOW );
+            return 1;
+        }
+
        /* now we can return it */
        if (!msg->unique_id) msg->unique_id = get_unique_id();
        reply->type   = MSG_HARDWARE;