qedit: Do not force the sample to be freed in SampleGrabber_callback().

Remove a work around that causes a crash in Unravel Two. There is a callback in Unravel Two that appears to add a reference to a IMediaSample, which this workaround treats as a leak and releases. However, the application also later releases the reference itself, causing a use-after-free. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51616Signed-off-by: Brendan McGrath <brendan@redmandi.com> Signed-off-by: Zebediah Figura <zfigura@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

qedit: Do not force the sample to be freed in SampleGrabber_callback().
1113f42a · Brendan McGrath · Alexandre Julliard · 2f280d0d · 1113f42a · 1113f42a
Commit 1113f42a authored Jul 17, 2022 by Brendan McGrath Committed by Alexandre Julliard Jul 18, 2022
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 4 deletions

samplegrabber.c dlls/qedit/samplegrabber.c +0 -3

mediadet.c dlls/qedit/tests/mediadet.c +1 -1

No files found.
--- a/dlls/qedit/samplegrabber.c
+++ b/dlls/qedit/samplegrabber.c
@@ -164,9 +164,6 @@ static void SampleGrabber_callback(struct sample_grabber *This, IMediaSample *sa
 		if (ref)
 		{
 		    ERR("(%p) Callback referenced sample %p by %lu\n", This, sample, ref);
-		    /* ugly as hell but some apps are sooo buggy */
-		    while (ref--)
-			IMediaSample_Release(sample);
 		}
 	    }
            break;

--- a/dlls/qedit/tests/mediadet.c
+++ b/dlls/qedit/tests/mediadet.c
@@ -1094,7 +1094,7 @@ static void test_samplegrabber(void)
    ok(samplecb_called == TRUE, "SampleCB should have been called\n");

    refcount = IUnknown_Release(&my_sample.sample);
-    todo_wine ok(!refcount, "Got unexpected refcount %ld.\n", refcount);
+    ok(!refcount, "Got unexpected refcount %ld.\n", refcount);

    IMemInputPin_Release(inpin);
    IPin_Release(pin);