Avoid trap in mixerGetLineControlsA when cControls is uninitialized

and MIXER_GETLINECONTROLSSF_ONEBYTYPE requested.

Avoid trap in mixerGetLineControlsA when cControls is uninitialized
17cff085 · Jason Edmeades · Alexandre Julliard · 1a7a4fbe · 17cff085
Commit 17cff085 authored Mar 15, 2005 by Jason Edmeades Committed by Alexandre Julliard Mar 15, 2005
Show whitespace changes
Inline Side-by-side

Showing with 8 additions and 0 deletions

winmm.c dlls/winmm/winmm.c +8 -0

No files found.
--- a/dlls/winmm/winmm.c
+++ b/dlls/winmm/winmm.c
@@ -488,7 +488,15 @@ UINT WINAPI mixerGetLineControlsA(HMIXEROBJ hmix, LPMIXERLINECONTROLSA lpmlcA,
    mlcW.dwLineID = lpmlcA->dwLineID;
    mlcW.u.dwControlID = lpmlcA->u.dwControlID;
    mlcW.u.dwControlType = lpmlcA->u.dwControlType;
+
+    /* Debugging on Windows shows for MIXER_GETLINECONTROLSF_ONEBYTYPE only,
+       the control count is assumed to be 1 - This is relied upon by a game,
+       "Dynomite Deluze"                                                    */
+    if (MIXER_GETLINECONTROLSF_ONEBYTYPE == fdwControls) {
+        mlcW.cControls = 1;
+    } else {
        mlcW.cControls = lpmlcA->cControls;
+    }
    mlcW.cbmxctrl = sizeof(MIXERCONTROLW);
    mlcW.pamxctrl = HeapAlloc(GetProcessHeap(), 0,
 			      mlcW.cControls * mlcW.cbmxctrl);