oleaut32: Extend value range before getting absolute value in VarBstrFromI4.

Signed-off-by: Daniel Lehman <dlehman@esri.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

oleaut32: Extend value range before getting absolute value in VarBstrFromI4.
1d2ac5d8 · Daniel Lehman · Alexandre Julliard · 7198499d · 1d2ac5d8 · 1d2ac5d8
Commit 1d2ac5d8 authored Jul 31, 2018 by Daniel Lehman Committed by Alexandre Julliard Aug 15, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

vartype.c dlls/oleaut32/tests/vartype.c +1 -1

vartype.c dlls/oleaut32/vartype.c +1 -1

No files found.
--- a/dlls/oleaut32/tests/vartype.c
+++ b/dlls/oleaut32/tests/vartype.c
@@ -4556,7 +4556,7 @@ static void test_VarBstrFromI4(void)
  ok(hres == S_OK, "got hres 0x%08x\n", hres);
  if (bstr)
  {
-    todo_wine ok(memcmp(bstr, int_min, sizeof(int_min)) == 0, "string different\n");
+    ok(memcmp(bstr, int_min, sizeof(int_min)) == 0, "string different\n");
    SysFreeString(bstr);
  }


--- a/dlls/oleaut32/vartype.c
+++ b/dlls/oleaut32/vartype.c
@@ -6453,7 +6453,7 @@ HRESULT WINAPI VarBstrFromI4(LONG lIn, LCID lcid, ULONG dwFlags, BSTR* pbstrOut)

  if (lIn < 0)
  {
-    ul64 = (ULONG)-lIn;
+    ul64 = -(LONG64)lIn;
    dwFlags |= VAR_NEGATIVE;
  }
  return VARIANT_BstrFromUInt(ul64, lcid, dwFlags, pbstrOut);