wininet/tests: Fix InternetGetConnectedStateEx() parameter checking.

It should set the error code if given a non-zero reserved value.

wininet/tests: Fix InternetGetConnectedStateEx() parameter checking.
1e2a24e9 · Francois Gouget · Alexandre Julliard · 6fa67bc8 · 1e2a24e9 · 1e2a24e9
Commit 1e2a24e9 authored Apr 07, 2023 by Francois Gouget Committed by Alexandre Julliard Apr 12, 2023
Hide whitespace changes
Inline Side-by-side

Showing with 8 additions and 0 deletions

internet.c dlls/wininet/internet.c +3 -0

internet.c dlls/wininet/tests/internet.c +5 -0

No files found.
--- a/dlls/wininet/internet.c
+++ b/dlls/wininet/internet.c
@@ -1216,7 +1216,10 @@ BOOL WINAPI InternetGetConnectedStateExW(LPDWORD lpdwStatus, LPWSTR lpszConnecti

    /* Must be zero */
    if(dwReserved)
+    {
+        SetLastError(ERROR_INVALID_PARAMETER);
        return FALSE;
+    }

    for (;;)
    {

--- a/dlls/wininet/tests/internet.c
+++ b/dlls/wininet/tests/internet.c
@@ -1759,6 +1759,11 @@ static void test_InternetGetConnectedStateExW(void)
    res = pInternetGetConnectedStateExW(NULL, NULL, 0, 0);
    ok(res == TRUE, "Expected TRUE, got %d\n", res);

+    SetLastError(0xdeadbeef);
+    res = pInternetGetConnectedStateExW(NULL, NULL, 0, 1);
+    ok(res == FALSE, "Expected TRUE, got %d\n", res);
+    ok(GetLastError() == ERROR_INVALID_PARAMETER, "Unexpected gle %lu\n", GetLastError());
+
    flags = 0;
    res = pInternetGetConnectedStateExW(&flags, NULL, 0, 0);
    ok(res == TRUE, "Expected TRUE, got %d\n", res);