mshtml/tests: Test document stream creation failure (Coverity).

Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com> Signed-off-by: Jacek Caban <jacek@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

mshtml/tests: Test document stream creation failure (Coverity).
286174a5 · Nikolay Sivov · Alexandre Julliard · 93eac48c · 286174a5 · 286174a5
Commit 286174a5 authored Jan 05, 2018 by Nikolay Sivov Committed by Alexandre Julliard Jan 05, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 10 additions and 4 deletions

activex.c dlls/mshtml/tests/activex.c +5 -2

dom.c dlls/mshtml/tests/dom.c +5 -2

No files found.
--- a/dlls/mshtml/tests/activex.c
+++ b/dlls/mshtml/tests/activex.c
@@ -2246,6 +2246,7 @@ static void doc_load_string(IHTMLDocument2 *doc, const char *str)
    IStream *stream;
    HGLOBAL mem;
    SIZE_T len;
+    HRESULT hr;

    notif_doc = doc;

@@ -2253,9 +2254,11 @@ static void doc_load_string(IHTMLDocument2 *doc, const char *str)
    len = strlen(str);
    mem = GlobalAlloc(0, len);
    memcpy(mem, str, len);
-    CreateStreamOnHGlobal(mem, TRUE, &stream);
+    hr = CreateStreamOnHGlobal(mem, TRUE, &stream);
+    ok(hr == S_OK, "Failed to create a stream, hr %#x.\n", hr);

-    IHTMLDocument2_QueryInterface(doc, &IID_IPersistStreamInit, (void**)&init);
+    hr = IHTMLDocument2_QueryInterface(doc, &IID_IPersistStreamInit, (void**)&init);
+    ok(hr == S_OK, "Failed to get IPersistStreamInit, hr %#x.\n", hr);

    IPersistStreamInit_Load(init, stream);
    IPersistStreamInit_Release(init);

--- a/dlls/mshtml/tests/dom.c
+++ b/dlls/mshtml/tests/dom.c
@@ -10518,6 +10518,7 @@ static IHTMLDocument2 *create_doc_with_string(const char *str)
    IHTMLDocument2 *doc;
    HGLOBAL mem;
    SIZE_T len;
+    HRESULT hr;

    notif_doc = doc = create_document();
    if(!doc)
@@ -10527,9 +10528,11 @@ static IHTMLDocument2 *create_doc_with_string(const char *str)
    len = strlen(str);
    mem = GlobalAlloc(0, len);
    memcpy(mem, str, len);
-    CreateStreamOnHGlobal(mem, TRUE, &stream);
+    hr = CreateStreamOnHGlobal(mem, TRUE, &stream);
+    ok(hr == S_OK, "Failed to create a stream, hr %#x.\n", hr);

-    IHTMLDocument2_QueryInterface(doc, &IID_IPersistStreamInit, (void**)&init);
+    hr = IHTMLDocument2_QueryInterface(doc, &IID_IPersistStreamInit, (void**)&init);
+    ok(hr == S_OK, "Failed to get IPersistStreamInit, hr %#x.\n", hr);

    IPersistStreamInit_Load(init, stream);
    IPersistStreamInit_Release(init);