Commit 2d542fa7 authored by Nikolay Sivov's avatar Nikolay Sivov Committed by Alexandre Julliard

shell32: Free cloned PIDL after tree initialization (Valgrind).

parent 99f0c0a1
...@@ -228,6 +228,7 @@ static void InitializeTreeView( browse_info *info ) ...@@ -228,6 +228,7 @@ static void InitializeTreeView( browse_info *info )
hr = SHGetDesktopFolder(&lpsfDesktop); hr = SHGetDesktopFolder(&lpsfDesktop);
if (FAILED(hr)) { if (FAILED(hr)) {
WARN("SHGetDesktopFolder failed! hr = %08x\n", hr); WARN("SHGetDesktopFolder failed! hr = %08x\n", hr);
ILFree(pidlChild);
return; return;
} }
hr = IShellFolder_BindToObject(lpsfDesktop, pidlParent, 0, &IID_IShellFolder, (LPVOID*)&lpsfParent); hr = IShellFolder_BindToObject(lpsfDesktop, pidlParent, 0, &IID_IShellFolder, (LPVOID*)&lpsfParent);
...@@ -236,6 +237,7 @@ static void InitializeTreeView( browse_info *info ) ...@@ -236,6 +237,7 @@ static void InitializeTreeView( browse_info *info )
if (FAILED(hr)) { if (FAILED(hr)) {
WARN("Could not bind to parent shell folder! hr = %08x\n", hr); WARN("Could not bind to parent shell folder! hr = %08x\n", hr);
ILFree(pidlChild);
return; return;
} }
...@@ -249,6 +251,7 @@ static void InitializeTreeView( browse_info *info ) ...@@ -249,6 +251,7 @@ static void InitializeTreeView( browse_info *info )
if (FAILED(hr)) { if (FAILED(hr)) {
WARN("Could not bind to root shell folder! hr = %08x\n", hr); WARN("Could not bind to root shell folder! hr = %08x\n", hr);
IShellFolder_Release(lpsfParent); IShellFolder_Release(lpsfParent);
ILFree(pidlChild);
return; return;
} }
...@@ -258,6 +261,7 @@ static void InitializeTreeView( browse_info *info ) ...@@ -258,6 +261,7 @@ static void InitializeTreeView( browse_info *info )
WARN("Could not get child iterator! hr = %08x\n", hr); WARN("Could not get child iterator! hr = %08x\n", hr);
IShellFolder_Release(lpsfParent); IShellFolder_Release(lpsfParent);
IShellFolder_Release(lpsfRoot); IShellFolder_Release(lpsfRoot);
ILFree(pidlChild);
return; return;
} }
...@@ -266,6 +270,7 @@ static void InitializeTreeView( browse_info *info ) ...@@ -266,6 +270,7 @@ static void InitializeTreeView( browse_info *info )
pidlParent, pEnumChildren, TVI_ROOT ); pidlParent, pEnumChildren, TVI_ROOT );
SendMessageW( info->hwndTreeView, TVM_EXPAND, TVE_EXPAND, (LPARAM)item ); SendMessageW( info->hwndTreeView, TVM_EXPAND, TVE_EXPAND, (LPARAM)item );
ILFree(pidlChild);
IShellFolder_Release(lpsfRoot); IShellFolder_Release(lpsfRoot);
IShellFolder_Release(lpsfParent); IShellFolder_Release(lpsfParent);
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment