ole32: Remove spurious AddRef of returned object on retrieval of an interface…

ole32: Remove spurious AddRef of returned object on retrieval of an interface from the global interface table.

ole32: Remove spurious AddRef of returned object on retrieval of an interface…
30cc2119 · Rob Shearman · Alexandre Julliard · 7d90b6ce · 30cc2119 · 30cc2119
Commit 30cc2119 authored May 22, 2007 by Rob Shearman Committed by Alexandre Julliard May 23, 2007
Hide whitespace changes
Inline Side-by-side

Showing with 0 additions and 5 deletions

git.c dlls/ole32/git.c +0 -4

marshal.c dlls/ole32/tests/marshal.c +0 -1

No files found.
--- a/dlls/ole32/git.c
+++ b/dlls/ole32/git.c
@@ -262,7 +262,6 @@ StdGlobalInterfaceTable_GetInterfaceFromGlobal(
 {
  StdGITEntry* entry;
  HRESULT hres;
-  LPUNKNOWN lpUnk;
  IStream *stream;

  TRACE("dwCookie=0x%x, riid=%s, ppv=%p\n", dwCookie, debugstr_guid(riid), ppv);
@@ -296,9 +295,6 @@ StdGlobalInterfaceTable_GetInterfaceFromGlobal(
    return hres;
  }

-  /* addref it */
-  lpUnk = *ppv;
-  IUnknown_AddRef(lpUnk);
  TRACE("ppv=%p\n", *ppv);
  return S_OK;
 }

--- a/dlls/ole32/tests/marshal.c
+++ b/dlls/ole32/tests/marshal.c
@@ -2651,7 +2651,6 @@ static void test_globalinterfacetable(void)
 	hr = IGlobalInterfaceTable_RevokeInterfaceFromGlobal(git, cookie);
 	ok_ole_success(hr, IGlobalInterfaceTable_RevokeInterfaceFromGlobal);

-	todo_wine
 	ok_no_locks();

 	IGlobalInterfaceTable_Release(git);