Skip to content

W
wine-cw
Commit 3111daa2 authored by Eric Pouech's avatar Eric Pouech Committed by Alexandre Julliard
Browse files
Options

dbghelp/dwarf: Validate that a string is in the section boundary before using it.

Signed-off-by: 's avatarEric Pouech <eric.pouech@gmail.com> Signed-off-by: 's avatarAlexandre Julliard <julliard@winehq.org>
parent 23f0ebbc
Hide whitespace changes
Inline Side-by-side
Showing with 13 additions and 3 deletions
dlls/dbghelp/dwarf.c
View file @ 3111daa2
......@@ -601,9 +601,19 @@ static BOOL dwarf2_fill_attr(const dwarf2_parse_context_t* ctx,
break;
case DW_FORM_strp:
attr->u.string = (const char*)ctx->sections[section_string].address +
dwarf2_get_addr(data, ctx->head.offset_size);
TRACE("strp<%s>\n", debugstr_a(attr->u.string));
{
ULONG_PTR ofs = dwarf2_get_addr(data, ctx->head.offset_size);
if (ofs >= ctx->sections[section_string].size)
{
ERR("Out of bounds string offset (%08lx)\n", ofs);
attr->u.string = "<<outofbounds-strp>>";
}
else
{
attr->u.string = (const char*)ctx->sections[section_string].address + ofs;
TRACE("strp<%s>\n", debugstr_a(attr->u.string));
}
}
break;
case DW_FORM_block:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment