Fixed a memory overflow and leak identified by Mike McCormack.

35706b6b · Aric Stewart · Alexandre Julliard · f3491aa9 · 35706b6b
Commit 35706b6b authored Aug 16, 2005 by Aric Stewart Committed by Alexandre Julliard Aug 16, 2005
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

action.c dlls/msi/action.c +2 -1

No files found.
--- a/dlls/msi/action.c
+++ b/dlls/msi/action.c
@@ -3709,7 +3709,7 @@ UINT ACTION_ResolveSource(MSIPACKAGE* package)
                INSTALLPROPERTY_DISKPROMPTW,NULL,&size);
        if (rc == ERROR_MORE_DATA)
        {
-            prompt = HeapAlloc(GetProcessHeap(),0,size);
+            prompt = HeapAlloc(GetProcessHeap(),0,size * sizeof(WCHAR));
            MsiSourceListGetInfoW(package->ProductCode, NULL, 
                    MSIINSTALLCONTEXT_USERMANAGED, MSICODE_PRODUCT,
                    INSTALLPROPERTY_DISKPROMPTW,prompt,&size);
@@ -3728,6 +3728,7 @@ UINT ACTION_ResolveSource(MSIPACKAGE* package)
            }
            attrib = GetFileAttributesW(package->PackagePath);
        }
+        HeapFree(GetProcessHeap(),0,prompt);
        rc = ERROR_SUCCESS;
    }
    else