Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-cw
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-cw
Commits
39ccd719
Commit
39ccd719
authored
Sep 06, 2023
by
Zebediah Figura
Committed by
Alexandre Julliard
Oct 06, 2023
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
objsel: Remove DLL refcount tracking.
Recent consensus seems to be that this isn't worth the effort.
parent
528fdc78
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
3 additions
and
47 deletions
+3
-47
factory.c
dlls/objsel/factory.c
+2
-18
objsel.c
dlls/objsel/objsel.c
+1
-23
objsel_private.h
dlls/objsel/objsel_private.h
+0
-6
No files found.
dlls/objsel/factory.c
View file @
39ccd719
...
...
@@ -66,20 +66,12 @@ static HRESULT WINAPI OBJSEL_IClassFactory_QueryInterface(
static
ULONG
WINAPI
OBJSEL_IClassFactory_AddRef
(
LPCLASSFACTORY
iface
)
{
ClassFactoryImpl
*
This
=
impl_from_IClassFactory
(
iface
);
ULONG
ref
;
TRACE
(
"
\n
"
);
if
(
This
==
NULL
)
return
E_POINTER
;
ref
=
InterlockedIncrement
(
&
This
->
ref
);
if
(
ref
==
1
)
{
InterlockedIncrement
(
&
dll_refs
);
}
return
ref
;
return
InterlockedIncrement
(
&
This
->
ref
);
}
...
...
@@ -89,20 +81,12 @@ static ULONG WINAPI OBJSEL_IClassFactory_AddRef(LPCLASSFACTORY iface)
static
ULONG
WINAPI
OBJSEL_IClassFactory_Release
(
LPCLASSFACTORY
iface
)
{
ClassFactoryImpl
*
This
=
impl_from_IClassFactory
(
iface
);
ULONG
ref
;
TRACE
(
"
\n
"
);
if
(
This
==
NULL
)
return
E_POINTER
;
ref
=
InterlockedDecrement
(
&
This
->
ref
);
if
(
ref
==
0
)
{
InterlockedDecrement
(
&
dll_refs
);
}
return
ref
;
return
InterlockedDecrement
(
&
This
->
ref
);
}
...
...
dlls/objsel/objsel.c
View file @
39ccd719
...
...
@@ -24,8 +24,6 @@
WINE_DEFAULT_DEBUG_CHANNEL
(
objsel
);
LONG
dll_refs
=
0
;
/***********************************************************************
* DllGetClassObject (OBJSEL.@)
*/
...
...
@@ -43,15 +41,6 @@ HRESULT WINAPI DllGetClassObject(REFCLSID rclsid, REFIID iid, LPVOID *ppv)
}
/***********************************************************************
* DllCanUnloadNow (OBJSEL.@)
*/
HRESULT
WINAPI
DllCanUnloadNow
(
void
)
{
return
dll_refs
!=
0
?
S_FALSE
:
S_OK
;
}
/**********************************************************************
* OBJSEL_IDsObjectPicker_Destroy (also IUnknown)
*/
...
...
@@ -74,20 +63,12 @@ static inline IDsObjectPickerImpl *impl_from_IDsObjectPicker(IDsObjectPicker *if
static
ULONG
WINAPI
OBJSEL_IDsObjectPicker_AddRef
(
IDsObjectPicker
*
iface
)
{
IDsObjectPickerImpl
*
This
=
impl_from_IDsObjectPicker
(
iface
);
ULONG
ref
;
TRACE
(
"
\n
"
);
if
(
This
==
NULL
)
return
E_POINTER
;
ref
=
InterlockedIncrement
(
&
This
->
ref
);
if
(
ref
==
1
)
{
InterlockedIncrement
(
&
dll_refs
);
}
return
ref
;
return
InterlockedIncrement
(
&
This
->
ref
);
}
...
...
@@ -106,10 +87,7 @@ static ULONG WINAPI OBJSEL_IDsObjectPicker_Release(IDsObjectPicker * iface)
ref
=
InterlockedDecrement
(
&
This
->
ref
);
if
(
ref
==
0
)
{
InterlockedDecrement
(
&
dll_refs
);
OBJSEL_IDsObjectPicker_Destroy
(
This
);
}
return
ref
;
}
...
...
dlls/objsel/objsel_private.h
View file @
39ccd719
...
...
@@ -24,12 +24,6 @@
#include "objsel.h"
/**********************************************************************
* Dll lifetime tracking declaration for objsel.dll
*/
extern
LONG
dll_refs
DECLSPEC_HIDDEN
;
/**********************************************************************
* ClassFactory declaration for objsel.dll
*/
typedef
struct
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment