Commit 39d2ce59 authored by Dmitry Timoshkov's avatar Dmitry Timoshkov Committed by Alexandre Julliard

ole32: Relax media type check when loading CF_METAFILEPICT format from OLE storage.

parent b8800c23
...@@ -282,10 +282,10 @@ static DataCacheEntry *DataCache_GetEntryForFormatEtc(DataCache *This, const FOR ...@@ -282,10 +282,10 @@ static DataCacheEntry *DataCache_GetEntryForFormatEtc(DataCache *This, const FOR
/* checks that the clipformat and tymed are valid and returns an error if they /* checks that the clipformat and tymed are valid and returns an error if they
* aren't and CACHE_S_NOTSUPPORTED if they are valid, but can't be rendered by * aren't and CACHE_S_NOTSUPPORTED if they are valid, but can't be rendered by
* DataCache_Draw */ * DataCache_Draw */
static HRESULT check_valid_clipformat_and_tymed(CLIPFORMAT cfFormat, DWORD tymed) static HRESULT check_valid_clipformat_and_tymed(CLIPFORMAT cfFormat, DWORD tymed, BOOL load)
{ {
if (!cfFormat || !tymed || if (!cfFormat || !tymed ||
(cfFormat == CF_METAFILEPICT && tymed == TYMED_MFPICT) || (cfFormat == CF_METAFILEPICT && (tymed == TYMED_MFPICT || load)) ||
(cfFormat == CF_BITMAP && tymed == TYMED_GDI) || (cfFormat == CF_BITMAP && tymed == TYMED_GDI) ||
(cfFormat == CF_DIB && tymed == TYMED_HGLOBAL) || (cfFormat == CF_DIB && tymed == TYMED_HGLOBAL) ||
(cfFormat == CF_ENHMETAFILE && tymed == TYMED_ENHMF)) (cfFormat == CF_ENHMETAFILE && tymed == TYMED_ENHMF))
...@@ -299,11 +299,11 @@ static HRESULT check_valid_clipformat_and_tymed(CLIPFORMAT cfFormat, DWORD tymed ...@@ -299,11 +299,11 @@ static HRESULT check_valid_clipformat_and_tymed(CLIPFORMAT cfFormat, DWORD tymed
} }
} }
static HRESULT DataCache_CreateEntry(DataCache *This, const FORMATETC *formatetc, DataCacheEntry **cache_entry) static HRESULT DataCache_CreateEntry(DataCache *This, const FORMATETC *formatetc, DataCacheEntry **cache_entry, BOOL load)
{ {
HRESULT hr; HRESULT hr;
hr = check_valid_clipformat_and_tymed(formatetc->cfFormat, formatetc->tymed); hr = check_valid_clipformat_and_tymed(formatetc->cfFormat, formatetc->tymed, load);
if (FAILED(hr)) if (FAILED(hr))
return hr; return hr;
if (hr == CACHE_S_FORMATETC_NOTSUPPORTED) if (hr == CACHE_S_FORMATETC_NOTSUPPORTED)
...@@ -1259,7 +1259,7 @@ static HRESULT add_cache_entry( DataCache *This, const FORMATETC *fmt, IStream * ...@@ -1259,7 +1259,7 @@ static HRESULT add_cache_entry( DataCache *This, const FORMATETC *fmt, IStream *
cache_entry = DataCache_GetEntryForFormatEtc( This, fmt ); cache_entry = DataCache_GetEntryForFormatEtc( This, fmt );
if (!cache_entry) if (!cache_entry)
hr = DataCache_CreateEntry( This, fmt, &cache_entry ); hr = DataCache_CreateEntry( This, fmt, &cache_entry, TRUE );
if (SUCCEEDED( hr )) if (SUCCEEDED( hr ))
{ {
DataCacheEntry_DiscardData( cache_entry ); DataCacheEntry_DiscardData( cache_entry );
...@@ -2007,7 +2007,7 @@ static HRESULT WINAPI DataCache_Cache( ...@@ -2007,7 +2007,7 @@ static HRESULT WINAPI DataCache_Cache(
return CACHE_S_SAMECACHE; return CACHE_S_SAMECACHE;
} }
hr = DataCache_CreateEntry(This, pformatetc, &cache_entry); hr = DataCache_CreateEntry(This, pformatetc, &cache_entry, FALSE);
if (SUCCEEDED(hr)) if (SUCCEEDED(hr))
{ {
......
...@@ -1215,13 +1215,7 @@ static void test_OleLoad(IStorage *pStorage) ...@@ -1215,13 +1215,7 @@ static void test_OleLoad(IStorage *pStorage)
hr = OleDraw(obj, DVASPECT_CONTENT, hdc, &rc); hr = OleDraw(obj, DVASPECT_CONTENT, hdc, &rc);
DeleteDC(hdc); DeleteDC(hdc);
if (fmt == CF_METAFILEPICT) if (fmt == CF_METAFILEPICT)
{
if (tymed == TYMED_HGLOBAL || tymed == TYMED_MFPICT)
ok(hr == S_OK, "OleDraw error %#x: cfFormat = %u, tymed = %u\n", hr, fmt, tymed); ok(hr == S_OK, "OleDraw error %#x: cfFormat = %u, tymed = %u\n", hr, fmt, tymed);
else
todo_wine
ok(hr == S_OK, "OleDraw error %#x: cfFormat = %u, tymed = %u\n", hr, fmt, tymed);
}
else if (fmt == CF_ENHMETAFILE) else if (fmt == CF_ENHMETAFILE)
todo_wine todo_wine
ok(hr == S_OK, "OleDraw error %#x: cfFormat = %u, tymed = %u\n", hr, fmt, tymed); ok(hr == S_OK, "OleDraw error %#x: cfFormat = %u, tymed = %u\n", hr, fmt, tymed);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment