winealsa.drv: Don't return garbage if can't find active channel.

3c070b22 · Dan Kegel · Alexandre Julliard · 95fbd7f4 · 3c070b22
Commit 3c070b22 authored Jan 13, 2008 by Dan Kegel Committed by Alexandre Julliard Jan 14, 2008
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 0 deletions

mixer.c dlls/winealsa.drv/mixer.c +6 -0

No files found.
--- a/dlls/winealsa.drv/mixer.c
+++ b/dlls/winealsa.drv/mixer.c
@@ -985,6 +985,12 @@ static DWORD MIX_GetControlDetails(UINT wDevID, LPMIXERCONTROLDETAILS mctrld, DW
                    break;
                }

+	    if (chn > SND_MIXER_SCHN_LAST)
+	    {
+		TRACE("can't find active channel\n");
+		return MMSYSERR_INVALPARAM;  /* fixme: what's right error? */
+	    }
+
            mcdb->fValue = !ival;
            TRACE("=> %s\n", mcdb->fValue ? "on" : "off");
            return MMSYSERR_NOERROR;