wusa: Zero out identity on error path in read_identity.

Fixes double frees in read_components and read_dependency. The double frees could also be fixed by using free instead of free_dependency in those functions, but zeroing out the pointers is easier to understand because it ensures that alloc_dependency can always be paired with free_dependency.

wusa: Zero out identity on error path in read_identity.
3caa27ea · Alex Henrie · Alexandre Julliard · 617117ce · 3caa27ea
Commit 3caa27ea authored Jun 10, 2023 by Alex Henrie Committed by Alexandre Julliard Jun 16, 2023
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 0 deletions

manifest.c programs/wusa/manifest.c +1 -0

No files found.
--- a/programs/wusa/manifest.c
+++ b/programs/wusa/manifest.c
@@ -275,6 +275,7 @@ static BOOL read_identity(IXMLDOMElement *root, struct assembly_identity *identi

 error:
    clear_identity(identity);
+    memset(identity, 0, sizeof(*identity));
    return FALSE;
 }