Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-cw
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-cw
Commits
3d2c8ef4
Commit
3d2c8ef4
authored
Jan 31, 2020
by
Nikolay Sivov
Committed by
Alexandre Julliard
Feb 02, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
ole32: Respond to CLSID in class moniker interface query.
Signed-off-by:
Nikolay Sivov
<
nsivov@codeweavers.com
>
Signed-off-by:
Alexandre Julliard
<
julliard@winehq.org
>
parent
a7ca3518
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
14 deletions
+6
-14
classmoniker.c
dlls/ole32/classmoniker.c
+4
-8
moniker.c
dlls/ole32/tests/moniker.c
+2
-6
No files found.
dlls/ole32/classmoniker.c
View file @
3d2c8ef4
...
...
@@ -60,24 +60,22 @@ static inline ClassMoniker *impl_from_IROTData(IROTData *iface)
/*******************************************************************************
* ClassMoniker_QueryInterface
*******************************************************************************/
static
HRESULT
WINAPI
ClassMoniker_QueryInterface
(
IMoniker
*
iface
,
REFIID
riid
,
void
**
ppvObject
)
static
HRESULT
WINAPI
ClassMoniker_QueryInterface
(
IMoniker
*
iface
,
REFIID
riid
,
void
**
ppvObject
)
{
ClassMoniker
*
This
=
impl_from_IMoniker
(
iface
);
TRACE
(
"
(%p,%s,%p)
\n
"
,
This
,
debugstr_guid
(
riid
),
ppvObject
);
TRACE
(
"
%p, %s, %p.
\n
"
,
iface
,
debugstr_guid
(
riid
),
ppvObject
);
/* Perform a sanity check on the parameters.*/
if
(
!
ppvObject
)
return
E_POINTER
;
/* Initialize the return parameter */
*
ppvObject
=
0
;
/* Compare the riid with the interface IDs implemented by this object.*/
if
(
IsEqualIID
(
&
IID_IUnknown
,
riid
)
||
IsEqualIID
(
&
IID_IPersist
,
riid
)
||
IsEqualIID
(
&
IID_IPersistStream
,
riid
)
||
IsEqualIID
(
&
IID_IMoniker
,
riid
))
IsEqualIID
(
&
IID_IMoniker
,
riid
)
||
IsEqualGUID
(
&
CLSID_ClassMoniker
,
riid
))
{
*
ppvObject
=
iface
;
}
...
...
@@ -93,11 +91,9 @@ static HRESULT WINAPI ClassMoniker_QueryInterface(IMoniker* iface,REFIID riid,vo
return
IUnknown_QueryInterface
(
This
->
pMarshal
,
riid
,
ppvObject
);
}
/* Check that we obtained an interface.*/
if
(
!*
ppvObject
)
return
E_NOINTERFACE
;
/* Query Interface always increases the reference count by one when it is successful */
IMoniker_AddRef
(
iface
);
return
S_OK
;
...
...
dlls/ole32/tests/moniker.c
View file @
3d2c8ef4
...
...
@@ -1773,13 +1773,9 @@ static void test_class_moniker(void)
ok_ole_success
(
hr
,
CreateClassMoniker
);
hr
=
IMoniker_QueryInterface
(
moniker
,
&
CLSID_ClassMoniker
,
(
void
**
)
&
unknown
);
todo_wine
ok
(
hr
==
S_OK
,
"Unexpected hr %#x.
\n
"
,
hr
);
if
(
SUCCEEDED
(
hr
))
{
ok
(
unknown
==
(
IUnknown
*
)
moniker
,
"Unexpected interface.
\n
"
);
IUnknown_Release
(
unknown
);
}
ok
(
unknown
==
(
IUnknown
*
)
moniker
,
"Unexpected interface.
\n
"
);
IUnknown_Release
(
unknown
);
test_moniker
(
"class moniker"
,
moniker
,
expected_class_moniker_marshal_data
,
sizeof
(
expected_class_moniker_marshal_data
),
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment