msi: Fixed missing free in an error path (Coverity).

3fa41c9e · Marcus Meissner · Alexandre Julliard · 6e25c34f · 3fa41c9e
Commit 3fa41c9e authored Mar 08, 2014 by Marcus Meissner Committed by Alexandre Julliard Mar 10, 2014
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 1 deletion

action.c dlls/msi/action.c +5 -1

No files found.
--- a/dlls/msi/action.c
+++ b/dlls/msi/action.c
@@ -5813,7 +5813,11 @@ static UINT ITERATE_InstallService(MSIRECORD *rec, LPVOID param)
        ERR("Query failed\n");
        goto done;
    }
-    if (!(key = MSI_RecordGetString(row, 6))) goto done;
+    if (!(key = MSI_RecordGetString(row, 6)))
+    {
+        msiobj_release(&row->hdr);
+        goto done;
+    }
    file = msi_get_loaded_file(package, key);
    msiobj_release(&row->hdr);
    if (!file)