comctl32: header: Ignore out-of-range iOrder in SetItemT.

414128eb · Mikołaj Zalewski · Alexandre Julliard · 2c86775d · 414128eb
Commit 414128eb authored May 30, 2006 by Mikołaj Zalewski Committed by Alexandre Julliard May 30, 2006
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

header.c dlls/comctl32/header.c +2 -2

No files found.
--- a/dlls/comctl32/header.c
+++ b/dlls/comctl32/header.c
@@ -1460,9 +1460,9 @@ HEADER_SetItemT (HWND hwnd, INT nItem, LPHDITEMW phdi, BOOL bUnicode)
    lpItem = &infoPtr->items[nItem];
    HEADER_StoreHDItemInHeader(lpItem, phdi->mask, phdi, bUnicode);

-    /* FIXME: check it order is not out of bound */
    if (phdi->mask & HDI_ORDER)
-        HEADER_ChangeItemOrder(infoPtr, nItem, phdi->iOrder);
+        if (phdi->iOrder >= 0 && phdi->iOrder < infoPtr->uNumItem)
+            HEADER_ChangeItemOrder(infoPtr, nItem, phdi->iOrder);

    HEADER_SendHeaderNotifyT (hwnd, HDN_ITEMCHANGEDW, nItem, phdi->mask, &hdNotify);